Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query aggregate instances by id #130

Open
wants to merge 4 commits into
base: feat/linked-vp
Choose a base branch
from

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Oct 4, 2024

Description of change

Adds the endpoints mentioned in #129

Blocked by

Links to any relevant issues

fixes issue #129

How the change has been tested

Tested through the updated Postman collection:

  • Issuance/offer
  • Issuance/credential
  • Verification/authorization_request
  • Holder/offer
  • Holder/credential
  • Holder/presentation

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@nanderstabel nanderstabel linked an issue Oct 4, 2024 that may be closed by this pull request
1 task
@nanderstabel nanderstabel self-assigned this Oct 4, 2024
@nanderstabel nanderstabel marked this pull request as ready for review October 4, 2024 19:23
Copy link
Contributor

@daniel-mader daniel-mader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest renaming the commit message to something more precise:

feat: add individual aggregate instance endpoints
-->
feat: query aggregate instances by id

@nanderstabel nanderstabel changed the title feat: add individual aggregate instance endpoints feat: query aggregate instances by id Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Something blocks the integration of this code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide API endpoints for individual aggregate instances
2 participants