Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bootstrap identity Connection aggregate #131

Open
wants to merge 6 commits into
base: nanderstabel/issue129
Choose a base branch
from

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Oct 5, 2024

Description of change

There are two important changes in this PR:

  1. The previous Connection aggregate in agent_verification is merged into the AuthorizationRequest aggregate.
  2. A new Connection aggregate is added to the agent_identity domain, this also means that two new endpoints are opened:
  • /connections both GET and POST: For GET additional query parameters can be added, for example: GET 'http://localhost:3033/v0/connections?did=did:example:123'
  • GET /connections/:connection_id: To query a Connection by connection_id

Blocked by

Links to any relevant issues

How the change has been tested

Added unit tests and added Postman Collection Requests

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@nanderstabel nanderstabel force-pushed the nanderstabel/issue125 branch 2 times, most recently from a46ebbc to ab20ce5 Compare October 9, 2024 11:40
@nanderstabel nanderstabel changed the title feat: init identity Connection aggregate feat: bootstrap identity Connection aggregate Oct 9, 2024
@nanderstabel nanderstabel self-assigned this Oct 9, 2024
@nanderstabel nanderstabel added Added A new feature that requires a minor release. Breaking change A change to the API that requires a major release. Blocked Something blocks the integration of this code. labels Oct 9, 2024
@nanderstabel nanderstabel marked this pull request as ready for review October 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release. Blocked Something blocks the integration of this code. Breaking change A change to the API that requires a major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant