Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Status field to Issuance's Offer and Credential aggregates #133

Open
wants to merge 1 commit into
base: nanderstabel/issue125
Choose a base branch
from

Conversation

nanderstabel
Copy link
Collaborator

Description of change

As title.

Also this PR introduces some slight refactor:
For both the Offer and Credential aggregates the corresponding OfferView and CredentialView are moved from the queries folder to the new views folder.

Blocked by

Links to any relevant issues

How the change has been tested

Updated existing unit tests

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@nanderstabel nanderstabel added the Enhancement New feature or improvement to an existing feature label Oct 9, 2024
@nanderstabel nanderstabel self-assigned this Oct 9, 2024
@nanderstabel nanderstabel changed the title feat: add Status field to Issuance Offer and Credential feat: add Status field to Issuance's Offer and Credential aggregates Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant