-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump oid4vc
and did_manager
dependencies
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a test for the `POST` method for the `credentials` endpoint that updates the `CREDENTIAL_LOCATION` environment variable
nanderstabel
force-pushed
the
chore/bump-oid4vc
branch
from
April 17, 2024 09:00
bf77daa
to
abd2277
Compare
nanderstabel
force-pushed
the
chore/bump-oid4vc
branch
from
April 17, 2024 09:12
abd2277
to
6a79666
Compare
nanderstabel
force-pushed
the
chore/bump-oid4vc
branch
from
April 19, 2024 13:06
ade49f2
to
f190ada
Compare
7 tasks
nanderstabel
added
Breaking change
A change to the API that requires a major release.
Dependencies
Issues related to an update of a dependency file
labels
Apr 19, 2024
nanderstabel
changed the title
chore: bump
chore: bump Apr 22, 2024
oid4vc
dependenciesoid4vc
and did_manager
dependencies
7 tasks
daniel-mader
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking change
A change to the API that requires a major release.
Dependencies
Issues related to an update of a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In this change, the
oid4vc
anddid_manager
dependencies are updated.AGENT_CONFIG_DEFAULT_DID_METHOD
environment variable is introduced which can be used to set the DID method that will be used as UniCore's identifier. When not set, it will default todid:key
Blocked by:
oid4vc-core
dependency did-manager#9Links to any relevant issues
How the change has been tested
Cross DID method testing is done through the updated
test_sign_authorization_request_object
test function inagent_verification
. With the help of#[rstest]
, the test will test the use of bothdid:key
anddid:jwk
.Manual testing through interaction with UniMe (through this PR: impierce/identity-wallet#197)
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.