Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump oid4vc and did_manager dependencies #44

Merged
merged 103 commits into from
Apr 24, 2024
Merged

Conversation

nanderstabel
Copy link
Collaborator

@nanderstabel nanderstabel commented Apr 17, 2024

Description of change

In this change, the oid4vc and did_manager dependencies are updated.

  • AGENT_CONFIG_DEFAULT_DID_METHOD environment variable is introduced which can be used to set the DID method that will be used as UniCore's identifier. When not set, it will default to did:key

Blocked by:

Links to any relevant issues

How the change has been tested

Cross DID method testing is done through the updated test_sign_authorization_request_object test function in agent_verification. With the help of #[rstest], the test will test the use of both did:key and did:jwk.
Manual testing through interaction with UniMe (through this PR: impierce/identity-wallet#197)

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel self-assigned this Apr 19, 2024
@nanderstabel nanderstabel added Breaking change A change to the API that requires a major release. Dependencies Issues related to an update of a dependency file labels Apr 19, 2024
@nanderstabel nanderstabel changed the title chore: bump oid4vc dependencies chore: bump oid4vc and did_manager dependencies Apr 22, 2024
@nanderstabel nanderstabel marked this pull request as ready for review April 22, 2024 12:31
@nanderstabel nanderstabel merged commit e858118 into dev Apr 24, 2024
1 check passed
@nanderstabel nanderstabel deleted the chore/bump-oid4vc branch April 24, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Dependencies Issues related to an update of a dependency file
Projects
Development

Successfully merging this pull request may close these issues.

2 participants