Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerise #194

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

Dockerise #194

wants to merge 54 commits into from

Conversation

jbothma
Copy link
Collaborator

@jbothma jbothma commented Jun 17, 2022

This is a LOT of changes - it's mostly for discussion - you probably want cleaner change sets, which I'm happy to try and assemble for you.

Changelog:

  • Add github actions workflow to run tests on each push and PR
  • Add .env to gitignore
  • Add Dockerfile that works in dev and production
  • Add docker-compose.yml to easily set up a dev environment
  • Add Procfile to run web and metrics processes in heroku or dokku
  • Add Docker-based instructions to README.md
  • Enable configuring using environment variables and document in README.md
  • Add example keys.js to enable setting via environment variables
  • Add session cookie support for single-component hostnames like localhost
  • Add default metrics config
  • Add npm lockfiles
  • Add nodemon dep
  • Bump node version to 14
  • Add start script which changes current working directory to start metrics without a different docker image

@impronunciable
Copy link
Owner

@jbothma This is awesome!

Since I don't have time to work on HackDash and it seems your org definitely has. Does it make sense to hand off the project development to you? cc @marianet

@jbothma
Copy link
Collaborator Author

jbothma commented Jul 28, 2022

Sorry for the slow reply - I've been away for a few weeks.

Let me think a bit with our CTO - do you mean just the codebase or running https://hackdash.org/ as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants