Removed rigger_type.snapshot so that delete triggers will now record …

…snapshots

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 3.4.8
+
+* Removed `trigger_type.snapshot` so that delete triggers will now record snapshots
+
+
 ## 3.4.7
 
 * Added a `HISTORY_IGNORE_MODELS` setting to ignore individual models. This should be a

history/backends/postgres.py

@@ -142,7 +142,7 @@ def create_trigger(self, model, trigger_type):
                 table=model._meta.db_table,
                 ctid=ct.pk,
                 pk_col=model._meta.pk.column,
-                snapshots=int(conf.SNAPSHOTS and trigger_type.snapshot),
+                snapshots=int(conf.SNAPSHOTS),
                 field_list=", '" + "', '".join(field_names) + "'",
             )
         )

history/backends/sqlite.py

@@ -66,7 +66,7 @@ def _json_snapshot(self, fields, trigger_type):
         Returns an SQL fragment that builds a JSON object from the specified model
         fields.
         """
-        if not conf.SNAPSHOTS or not trigger_type.snapshot:
+        if not conf.SNAPSHOTS:
             return "NULL"
         return self._json_object(fields, "NEW")
 

history/models.py

@@ -12,10 +12,6 @@ class TriggerType(models.TextChoices):
     DELETE = "D", _("Delete")
     UPDATE = "U", _("Update")
 
-    @property
-    def snapshot(self):
-        return self in (TriggerType.INSERT, TriggerType.UPDATE)
-
     @property
     def changes(self):
         return self == TriggerType.UPDATE