added snapshot_of to fix tests

imsweb · May 20, 2024 · cd12499 · cd12499
1 parent 32ddc3c
commit cd12499
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/history/backends/sqlite.py b/history/backends/sqlite.py
@@ -68,7 +68,7 @@ def _json_snapshot(self, fields, trigger_type):
         """
         if not conf.SNAPSHOTS:
             return "NULL"
-        return self._json_object(fields, "NEW")
+        return self._json_object(fields, trigger_type.snapshot_of)
 
     def _json_changes(self, fields, trigger_type):
         """

diff --git a/history/models.py b/history/models.py
@@ -12,6 +12,10 @@ class TriggerType(models.TextChoices):
     DELETE = "D", _("Delete")
     UPDATE = "U", _("Update")
 
+    @property
+    def snapshot_of(self):
+        return "OLD" if self == TriggerType.DELETE else "NEW"
+
     @property
     def changes(self):
         return self == TriggerType.UPDATE

diff --git a/tests/custom/tests.py b/tests/custom/tests.py
@@ -84,7 +84,7 @@ def test_basics(self):
         # Check delete history.
         self.assertEqual(delete.session_id, session.session_id)
         self.assertEqual(delete.get_user(), "nobody")
-        self.assertIsNone(delete.snapshot)
+        self.assertEqual(delete.snapshot, {"id": pk, "name": "Somebody"})
         self.assertIsNone(delete.changes)
 
     def test_no_session(self):
@@ -137,7 +137,8 @@ def test_data_types(self):
         self.assertEqual(update.changes["data"][0], data)
         self.assertEqual(update.changes["data"][1], replace(data, answer=420))
         self.assertEqual(uuid.UUID(update.snapshot["ident"]), obj.ident)
-        self.assertIsNone(delete.snapshot)
+        self.assertEqual(delete.snapshot["data"], replace(data, answer=420))
+        self.assertEqual(uuid.UUID(delete.snapshot["ident"]), obj.ident)
         self.assertIsNone(delete.changes)
 
     def test_change_pk(self):