feat: adding git remotes to subjects and normalising url #361
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
adityasaky
reviewed
Sep 26, 2024
| "github.com/in-toto/go-witness", | ||
| "github.com/in-toto/go-witness.git", | ||
| "https://github.com/in-toto/go-witness", | ||
| "https://github.com/in-toto/go-witness.git", |
There was a problem hiding this comment.
I think it may be worth testing with git:// and git+ssh etc, even though some of those are deprecated. I think some SCPs (possibly sourceforge?) sets git:// to be default.
There was a problem hiding this comment.
a-ha - I will!
adityasaky
reviewed
Sep 26, 2024
| @@ -103,6 +103,7 @@ require ( | |||
| github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966 // indirect | |||
| github.com/tchap/go-patricia/v2 v2.3.1 // indirect | |||
| github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399 // indirect | |||
| github.com/whilp/git-urls v1.0.0 // indirect | |||
There was a problem hiding this comment.
weird this is marked indirect? 🤔 go mod tidy?
There was a problem hiding this comment.
yeah I'll run and see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Description
This PR adds the repository remotes to the subjects of the in-toto statement for more easy querying of understanding the identity of a repository. It also normalises the remote url, in an attempt to make it agnostic to the protocol used in that config to connect to the remote (e.g.,
http:///ssh).