Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KMS/Remote Signing Support #278

Open
mikhailswift opened this issue Aug 24, 2023 · 1 comment
Open

KMS/Remote Signing Support #278

mikhailswift opened this issue Aug 24, 2023 · 1 comment
Labels
needs triage Issues to triage

Comments

@mikhailswift
Copy link
Member

mikhailswift commented Aug 24, 2023

Currently we support a variety of different signers, including Fulcio and Vault PKI, but these all will result in private key material being loaded into memory to sign data locally.

We should be able to support using KMS solutions to do signing for us. Some example KMS solutions we'd like to support:

  1. AWS KMS
  2. GCP KMS
  3. Vault Transit Secret Engine

Some considerations we need to account for:

  1. Our current Signer interface does not take in a context to it's Sign function. With calls happening to remote resources we need to be able to have a context for cancellation purposes.

  2. A new class of errors. This isn't a huge consideration since we already have error handling in our signing code, but there may be some subtleties we have to account for.

  3. Verification. We may not be able to reach the KMS solution during verification, for example we could be in an air gapped environment or not have cloud permissions to reach the KMS. For keys backed by X509 certificates we need to make sure we receive the certificate from the kms solution. For keys that are not, the user will be responsible for embedding the public portion of the key into their policy.

@mikhailswift
Copy link
Member Author

Also, for reference, cosign has run into some rough edges with key rotations and versioning. While this issue is focused on the Vault Transit Engine implementation, this could be an issue for other KMS solutions as well.

@jkjell jkjell added the needs triage Issues to triage label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issues to triage
Projects
None yet
Development

No branches or pull requests

2 participants