Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git LFS support for git attestor #317

Open
matglas opened this issue Dec 1, 2023 · 3 comments
Open

Git LFS support for git attestor #317

matglas opened this issue Dec 1, 2023 · 3 comments

Comments

@matglas
Copy link
Contributor

matglas commented Dec 1, 2023

When attesting a git repo with lfs objects it shows files as being changed. But they are just checked out files. The attestation showing a changed state and all the lfs objects looks strange. Maybe it should check if the state of the lfs objects is correct based on the data in the repo. Just thinking out load.

@mikhailswift
Copy link
Member

mikhailswift commented Dec 1, 2023

We use go-git for our git attestor and it looks like they currently don't support LFS:

https://github.com/go-git/go-git/blob/4f614891047bae5d0f7a253f014175505b9821d7/COMPATIBILITY.md?plain=1#L93

However, we may be able to contribute to go-git for this support, or investigate other solutions to!

@matglas
Copy link
Contributor Author

matglas commented Dec 4, 2023

As its mainly to get lfs status it could be enough to right a complementary status part into go-git just to verify lfs. I noticed from the issues they have on their go-git repo that git-lfs is not that ready for including it as a go module, even though their tooling is written as a go module. They have a pretty unstable API as they say themselves.

@colek42
Copy link
Member

colek42 commented Dec 7, 2023

would the omnitrail stuff we are doing help here? cc @fkautz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants