-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SBOM and Omnitrail Attestor #464
Conversation
…pdate to git attestor Signed-off-by: John Kjell <john@testifysec.com>
✅ Deploy Preview for witness-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: John Kjell <john@testifysec.com>
@@ -0,0 +1,148 @@ | |||
## Schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have docs for this new attestor. @fkautz maybe you have a couple mins to add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #465 to not block this PR.
@@ -133,7 +133,6 @@ func runRun(ctx context.Context, ro options.RunOptions, args []string, signers . | |||
witness.RunWithAttestors(attestors), | |||
witness.RunWithAttestationOpts(attestation.WithWorkingDir(ro.WorkingDir), attestation.WithHashes(roHashes)), | |||
witness.RunWithTimestampers(timestampers...), | |||
witness.RunWithSigners(signers...), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, we were calling this twice?
…cing support) Signed-off-by: John Kjell <john@testifysec.com>
Signed-off-by: John Kjell <john@testifysec.com>
Signed-off-by: John Kjell <john@testifysec.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add new go-witness SBOM attestor.
Acceptance Criteria Met