Implement parallel broadcall #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 92.34% 92.54% +0.20%
==========================================
Files 10 10
Lines 444 456 +12
==========================================
+ Hits 410 422 +12
Misses 34 34 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
parallel_broadcall
branch
2 times, most recently
from
e80731f to
3871d30
Compare
NelsonVides
force-pushed
the
parallel_broadcall
branch
from
3871d30 to
2f0a95a
Compare
NelsonVides
force-pushed
the
parallel_broadcall
branch
from
2f0a95a to
52bdd15
Compare
Merged
elbrujohalcon
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #121 but doing all the calls at once, in parallel, and then waiting for the timeouts one by one. I'm experimenting a bit with this one so I'm looking for some good feedback, if the return values are understandable, usable, if this is wanted, if the implementation is clear, etc 🙃