-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
styleguide R code has no referral to tidyverse style guide #118
Comments
I agree, good point! |
The Tidyverse style guide is good and community maintained, so pointing to that one (with maybe some specific INBO clarifications) would be less maintenance for us. @ThierryO is there much in our style guide that differs from the Tidyverse style guide? If so, are there good reasons for them? |
Ok to refer to it as an additional guideline. As it is rather long, I think it would be nice to keep a short list of the most important rules/guidelines in our tutorial (to not force everyone to read the whole guideline). And of course the items that are specific for INBO. From memory: adding INBO as copyrighter is something that is unique to our guideline. ;-) |
While working on PR #117, I'm wondering: is the guideline not growing too long for one page? If I am not mistaken, it was first written for package development (some years ago), and only after a comment I noticed it is now used more general. Because all different subjects are mixed, it becomes a bit confusing and difficult to pick the right things. Would it be a good idea to split this page in 3 different pages?
|
After discussion yesterday: current suggestion is to refer to the Further, if a vignette in |
While reading into issue #116 on the INBO R styleguide, and myself rather using the tidyverse style guide, I wonder why we don't just refer to the latter and redirect people there (and if needed, propose enhancements there). It seems to me that we want to adhere to it anyway. Maybe I overlook things ;-)
Currently, there is no referral to the tidyverse style guide at all, which is the main point of this issue.
The text was updated successfully, but these errors were encountered: