fuzz/*: fuzz rats-tls APIs in sgx mode #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-cpy
force-pushed
the
fuzz_sgx
branch
4 times, most recently
from
673d835
to
f13edd0
Compare
Ben-cpy
force-pushed
the
fuzz_sgx
branch
2 times, most recently
from
83bc27e
to
897b012
Compare
Ben-cpy
force-pushed
the
fuzz_sgx
branch
2 times, most recently
from
1f27728
to
3fbcf16
Compare
haosanzi
reviewed
Oct 31, 2023
| set(SGX_COMMON_CXXFLAGS "${SGX_COMMON_FLAGS} -Wnon-virtual-dtor -std=c++11") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -std=gnu11 -fPIC -Werror=implicit-function-declaration") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
if((BUILD_FUZZ) AND (SGX))
string(REPLACE "-std=gnu11" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
string(REPLACE "-std=c11" "" SGX_COMMON_FLAGS "${SGX_COMMON_FLAGS}")
string(REPLACE "-std=c++11" "" SGX_COMMON_CXXFLAGS "${SGX_COMMON_CXXFLAGS}")
haosanzi
reviewed
Oct 31, 2023
haosanzi
reviewed
Oct 31, 2023
haosanzi
reviewed
Oct 31, 2023
haosanzi
reviewed
Oct 31, 2023
haosanzi
reviewed
Oct 31, 2023
haosanzi
reviewed
Oct 31, 2023
haosanzi
reviewed
Oct 31, 2023
fuzz/tls_sgx_mode/fuzz_sgx_mode.cc
Outdated
| char verifier_types[10][25] = { "nullverifier", "", "sgx_la", | ||
| "csv", "sev", "sev_snp", | ||
| "tdx_ecdsa", "tdx_ecdsa", "sgx_ecdsa_qve" }; | ||
| strcpy(verifier_types[9], fuzzed_data.ConsumeBytesWithTerminator(20, '\0').data()); |
There was a problem hiding this comment.
Did not use verifier_types in the following code.
There was a problem hiding this comment.
so I just comment this line 95-98 ?
haosanzi
reviewed
Oct 31, 2023
fuzz/tls_sgx_mode/fuzz_sgx_mode.cc
Outdated
| uint16_t s_port = htons((uint16_t)FUZZ_PORT); | ||
|
|
||
| char * attester_type = (char *)malloc(20); | ||
| if(attester_type == NULL){ |
There was a problem hiding this comment.
char * attester_type to char *attester_type . please check the other code
use libfuzzer to fuzz rats-tls API `rats_tls_init()`, `rats_tls_negotiate()`, `rats_tls_transmit()`, `rats_tls_receive()`, `rats_tls_cleanup()` in sgx mode. Signed-off-by: Pengyu Chen <chenpengyu_1024@163.com>
haosanzi
reviewed
Nov 6, 2023
| @@ -58,6 +62,11 @@ if(SGX) | |||
|
|
|||
| set(SGX_COMMON_CFLAGS "${SGX_COMMON_FLAGS} -Wstrict-prototypes -Wunsuffixed-float-constants -Wno-implicit-function-declaration -std=c11") | |||
| set(SGX_COMMON_CXXFLAGS "${SGX_COMMON_FLAGS} -Wnon-virtual-dtor -std=c++11") | |||
| if((BUILD_FUZZ) AND (SGX)) | |||
There was a problem hiding this comment.
remove AND (SGX) ,since if(SGX) is in line 21,
haosanzi
reviewed
Nov 7, 2023
| @@ -12,6 +12,10 @@ else() | |||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2") | |||
| endif() | |||
|
|
|||
| if((BUILD_FUZZ) AND (SGX)) | |||
| string(REPLACE "-std=gnu11" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}") | |||
| endif() | |||
There was a problem hiding this comment.
please remove this code to line 65
Ben-cpy
force-pushed
the
fuzz_sgx
branch
2 times, most recently
from
cf1d777
to
2f6f25f
Compare
Ben-cpy
force-pushed
the
fuzz_sgx
branch
2 times, most recently
from
9898753
to
fb8ba10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use libfuzzer to fuzz rats-tls API
rats_tls_init(),rats_tls_negotiate(),rats_tls_transmit()andrats_tls_receive()in sgx mode