feat: Convert the BMW encoding to JSON #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amb26
reviewed
Aug 3, 2023
docs/ConvertBMWToJSON.md
Outdated
| that will serve as the foundation for implementing the BMW input method. | ||
|
|
||
| BMW encoding documents are in PDF format. These PDFs are composed by digitalized images of orginal | ||
| books. The coversio method is: |
There was a problem hiding this comment.
Typo coversio -> conversion -
Also "digitized" is better rendering of "digitalized"
amb26
reviewed
Aug 3, 2023
docs/ConvertBMWToJSON.md
Outdated
| books. The coversio method is: | ||
|
|
||
| 1. Split every single page in a PDF into .jpg files | ||
| 2. Use OCR library to extract texts from .jpg files |
There was a problem hiding this comment.
Do we have a working OCR library for this? Could we provide more detailed instructions?
amb26
reviewed
Aug 3, 2023
docs/ConvertBMWToJSON.md
Outdated
| BMW encoding documents are in PDF format. These PDFs are composed by digitalized images of orginal | ||
| books. The coversio method is: | ||
|
|
||
| 1. Split every single page in a PDF into .jpg files |
There was a problem hiding this comment.
Split each page in the PDF into its own .jpg file
amb26
reviewed
Aug 3, 2023
utils/README.md
Outdated
|
|
||
| **File formats** | ||
|
|
||
| 1. The content of any .txt file in the `source_txt_path` directory |
|
Thanks for the review, @amb26. All addressed and ready for another round. |
fix: adding missing bci-av-ids in ../data/bmw.json
|
|
fix: making some fixes and adding missing bci-av-ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request converts the BMW encoding to a JSON file to be used for the future development.
Steps to test
Refer to the document Convert BMW encoding to JSON about steps to convert.
Additional information
Due to the copyright concern, the original BMW encoding files are not included in this pull request.