Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experiment with Llama2 (resolves #18) #19

Merged
merged 20 commits into from
Apr 26, 2024

Conversation

cindyli
Copy link
Contributor

@cindyli cindyli commented Feb 16, 2024

The documentation in docs/Llama2FineTuning.md describes experiments with Llama2 models and results. This pull request also includes scripts used in the experiment.

Copy link
Contributor

@klown klown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cindyli, I found a few things for you to think about changing. However, I do not have the expertise regarding the specifics of training Llama-2 nor testing it , nor the HuggingFace interface. You might want to have someone else with more experience to look that over, but I'm not sure who that would be. Angel?

docs/Llama2FineTuning.md Outdated Show resolved Hide resolved
docs/Llama2FineTuning.md Show resolved Hide resolved
docs/Llama2FineTuning.md Show resolved Hide resolved
docs/Llama2FineTuning.md Outdated Show resolved Hide resolved
docs/Llama2FineTuning.md Outdated Show resolved Hide resolved
jobs/Llama2/finetune/job_eval_7b_hf.sh Outdated Show resolved Hide resolved
jobs/Llama2/finetune/job_eval_generated_sentence.sh Outdated Show resolved Hide resolved
jobs/Llama2/finetune/job_finetune_7b_hf.sh Outdated Show resolved Hide resolved
jobs/Llama2/original_use/job_original_use_7b_hf.sh Outdated Show resolved Hide resolved
jobs/Llama2/original_use/original_use_7b_hf.py Outdated Show resolved Hide resolved
@cindyli
Copy link
Contributor Author

cindyli commented Apr 10, 2024

@klown thanks for the review and great suggestions. All comments are addressed. It's ready for another look.

I emailed David and Angel to find out if they could review and provide feedback. Let's see how it goes.

@cindyli cindyli requested a review from agamba April 17, 2024 15:38
@cindyli
Copy link
Contributor Author

cindyli commented Apr 17, 2024

@agamba as we discussed in the technical meeting yesterday, in the docs/Llama2FineTuning.md, I added a section "future improvements" with a few potential issues that can be improved. Could you have a look and let me know what you think? Thanks.

docs/Llama2FineTuning.md Show resolved Hide resolved
jobs/Llama2/finetune/eval_7b_hf.py Show resolved Hide resolved
jobs/Llama2/finetune/eval_7b_hf.py Show resolved Hide resolved
@cindyli
Copy link
Contributor Author

cindyli commented Apr 22, 2024

Also, I remember that we have a shared directory. We used it to share our StyleGAN results with David. It's here: ~/projects/ctb-whkchun/s2_bliss. Is it possible to put the LLama LLM in that directory? Then we could all share it.

All models I downloaded are placed in ~/projects/ctb-whkchun/s2_bliss_LLMs. This folder name has a suffix "_LLMs". All models in there are available to share.

@cindyli
Copy link
Contributor Author

cindyli commented Apr 22, 2024

@klown all new comments have been addressed. Ready for another look. Thanks.

Copy link
Contributor

@klown klown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cindyli, there is one last unused variable to get rid of, and then it's good as far as I'm concerned.

@@ -46,20 +48,19 @@ def generate_text_with_prompt(prompt, model, tokenizer, temperature=0.7):
# Test with exactly same instructions used in fine-tuning
instruction = "### Instruction: \nConvert the input English sentence to a Bliss sentence.\n\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instruction variable is not needed anymore, since the instructions_map is used instead, on the next and subsequent lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, @klown. Now addressed. Thanks.

Copy link
Contributor

@klown klown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cindyli cindyli merged commit 3f6e183 into inclusive-design:main Apr 26, 2024
2 checks passed
@cindyli cindyli deleted the feat/Llama2 branch May 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants