From 5ffafa09645d650f0a75e73a4de3461bd9318a12 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Tue, 20 Jun 2023 17:07:31 -0300 Subject: [PATCH 01/12] feat: add external and download icons adjacent to relevant links automatically --- src/_includes/svg/icon-download.svg | 1 + src/assets/styles/base/_base.scss | 19 +++++++++++-------- src/assets/styles/base/_typography.scss | 5 +++++ src/assets/styles/pages/_generic.scss | 1 + src/transforms/parse.js | 12 +++++++++++- 5 files changed, 29 insertions(+), 9 deletions(-) create mode 100644 src/_includes/svg/icon-download.svg diff --git a/src/_includes/svg/icon-download.svg b/src/_includes/svg/icon-download.svg new file mode 100644 index 00000000..01e09f81 --- /dev/null +++ b/src/_includes/svg/icon-download.svg @@ -0,0 +1 @@ + diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index 5692a0eb..723d5166 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -35,18 +35,21 @@ a:focus { outline: none; } +a[hreflang], +a[download], +a[rel="external"] { + svg { + display: inline-block; + margin-left: 0.25em; + margin-right: 0.25em; + width: 1em; + } +} + a[hreflang] { - align-items: center; - display: inline-flex; font-size: var(--step-1); font-weight: var(--fw-semibold); margin-top: var(--step-2); - - svg { - display: block; - margin-right: 0.5em; - width: var(--step-1); - } } .content a:visited { diff --git a/src/assets/styles/base/_typography.scss b/src/assets/styles/base/_typography.scss index a94407fb..417b34e2 100755 --- a/src/assets/styles/base/_typography.scss +++ b/src/assets/styles/base/_typography.scss @@ -79,6 +79,11 @@ h4 + *, margin-top: rem(30); } +* + h5, +* + .h5 { + margin-top: var(--step-2); +} + @include breakpoint-up(md) { :root { --step-1: calc(22 / 16 * 1rem); diff --git a/src/assets/styles/pages/_generic.scss b/src/assets/styles/pages/_generic.scss index 8c7bbaed..ca47b53a 100644 --- a/src/assets/styles/pages/_generic.scss +++ b/src/assets/styles/pages/_generic.scss @@ -80,6 +80,7 @@ main > article { } } +hr, .hr { border-bottom: rem(2) solid; display: block; diff --git a/src/transforms/parse.js b/src/transforms/parse.js index a31da252..1cf2d581 100644 --- a/src/transforms/parse.js +++ b/src/transforms/parse.js @@ -39,9 +39,19 @@ module.exports = (value, outputPath) => { for (const link of links) { if ( !link.href.startsWith('/') && - (!['localhost:3000', 'idrc.ocadu.ca'].includes(link.host) || !link.host.endsWith('idrc.netlify.app')) + (!['localhost:3000', 'localhost:8080', 'idrc.ocadu.ca'].includes(link.host) || !link.host.endsWith('idrc.netlify.app')) ) { link.setAttribute('rel', 'external'); + if (!link.closest('nav')) { + link.innerHTML = `${link.innerHTML}`; + } + } + + if ( + link.href.endsWith('.docx') || link.href.endsWith('.pdf') + ) { + link.setAttribute('download', ''); + link.innerHTML = `${link.innerHTML}`; } } } From 9eabc7e7b540c1f52f453a6ce77c40d9323e69ad Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Tue, 20 Jun 2023 17:16:16 -0300 Subject: [PATCH 02/12] fix: remove some duplication --- src/assets/styles/base/_base.scss | 24 ++++++++++++------------ src/transforms/parse.js | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index 723d5166..9a0ee0d0 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -73,18 +73,18 @@ main h4, padding-left: 1em; } - a[rel~='external']::after, - a[href^='mailto:']::after { - background-color: currentcolor; - content: ''; - margin-bottom: rem(-4); - margin-left: rem(4); - mask-image: url('../images/external.svg'); - mask-position: center; - mask-repeat: no-repeat; - mask-size: 1.5em; - padding-left: 1em; - } + // a[rel~='external']::after, + // a[href^='mailto:']::after { + // background-color: currentcolor; + // content: ''; + // margin-bottom: rem(-4); + // margin-left: rem(4); + // mask-image: url('../images/external.svg'); + // mask-position: center; + // mask-repeat: no-repeat; + // mask-size: 1.5em; + // padding-left: 1em; + // } } blockquote { diff --git a/src/transforms/parse.js b/src/transforms/parse.js index 1cf2d581..c2570c7f 100644 --- a/src/transforms/parse.js +++ b/src/transforms/parse.js @@ -42,7 +42,7 @@ module.exports = (value, outputPath) => { (!['localhost:3000', 'localhost:8080', 'idrc.ocadu.ca'].includes(link.host) || !link.host.endsWith('idrc.netlify.app')) ) { link.setAttribute('rel', 'external'); - if (!link.closest('nav')) { + if (!link.closest('nav') && link.className !== 'project__link') { link.innerHTML = `${link.innerHTML}`; } } From 94a39681eb14672143379a8efd8d44dd4844928c Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Tue, 20 Jun 2023 17:18:26 -0300 Subject: [PATCH 03/12] fix: resolve linting issue --- src/assets/styles/base/_base.scss | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index 9a0ee0d0..72727dd9 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -72,19 +72,6 @@ main h4, mask-size: 1.5em; padding-left: 1em; } - - // a[rel~='external']::after, - // a[href^='mailto:']::after { - // background-color: currentcolor; - // content: ''; - // margin-bottom: rem(-4); - // margin-left: rem(4); - // mask-image: url('../images/external.svg'); - // mask-position: center; - // mask-repeat: no-repeat; - // mask-size: 1.5em; - // padding-left: 1em; - // } } blockquote { From 3185c18cef074a7f01f6b036fd5ec8260ee16d89 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Tue, 20 Jun 2023 17:23:05 -0300 Subject: [PATCH 04/12] fix: resolve lint error --- src/assets/styles/base/_base.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index 72727dd9..76bef24c 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -37,7 +37,7 @@ a:focus { a[hreflang], a[download], -a[rel="external"] { +a[rel='external'] { svg { display: inline-block; margin-left: 0.25em; From 32c48bf4b968d1baeed977471ef3b8a0d874b9d6 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 12:28:28 -0300 Subject: [PATCH 05/12] chore: fix links with empty text on project pages --- .../en-CA/communication-access-reports.md | 2 +- ...access-within-the-accessible-canada-act.md | 4 +--- ...uture-of-work-equitable-digital-systems.md | 19 ++++++++----------- src/projects/en-CA/odd.md | 2 +- 4 files changed, 11 insertions(+), 16 deletions(-) diff --git a/src/projects/en-CA/communication-access-reports.md b/src/projects/en-CA/communication-access-reports.md index f47571da..4286bb78 100644 --- a/src/projects/en-CA/communication-access-reports.md +++ b/src/projects/en-CA/communication-access-reports.md @@ -10,7 +10,7 @@ parentTitle: Communication Access within the Accessible Canada Act [Part One: Framing Communication Accessibility in the Canadian Context](/media/commacc-part-1_framing-report_en.docx) -[](/media/commacc-part-1_framing-report_en.docx)[Part Two: Scope of Communication Access Approaches and Supports for in Federally Regulated Contexts](/media/commacc-part-2_scoping-report_en.docx) +[Part Two: Scope of Communication Access Approaches and Supports for in Federally Regulated Contexts](/media/commacc-part-2_scoping-report_en.docx) [Part Three: Recommendations for Improving Communication Access in Federally Regulated Contexts](/media/commacc-part-3_recommendations_en.docx) diff --git a/src/projects/en-CA/communication-access-within-the-accessible-canada-act.md b/src/projects/en-CA/communication-access-within-the-accessible-canada-act.md index ea34e0e5..4e9c6733 100644 --- a/src/projects/en-CA/communication-access-within-the-accessible-canada-act.md +++ b/src/projects/en-CA/communication-access-within-the-accessible-canada-act.md @@ -35,7 +35,7 @@ Global and national scan of existing data and research related to incidence and [Part One: Framing Communication Accessibility in the Canadian Context](/media/commacc-part-1_framing-report_en.docx) -[](/media/commacc-part-1_framing-report_en.docx)[Part Two: Scope of Communication Access Approaches and Supports for in Federally Regulated Contexts](/media/commacc-part-2_scoping-report_en.docx) +[Part Two: Scope of Communication Access Approaches and Supports for in Federally Regulated Contexts](/media/commacc-part-2_scoping-report_en.docx) [Part Three: Recommendations for Improving Communication Access in Federally Regulated Contexts](/media/commacc-part-3_recommendations_en.docx) @@ -154,8 +154,6 @@ Ali Kazmi is a research assistant for OCAD’s Inclusive Design Research Centre. Shalaine Sedres is a graduate student pursuing a Master’s degree at the University of Toronto’s Rehabilitation Science Institute. She obtained her Bachelor’s degree in Community Rehabilitation and Disability Studies from the University of Calgary. As a research assistant, Shalaine has made valuable contributions to the Inclusive Design Research Centre’s Equitable Digital Systems project by facilitating co-design sessions and interpreting insights. Her current research focuses on leveraging accessible playgrounds by incorporating rehabilitation and educational programming. She is dedicated to promoting inclusivity and reducing barriers that hinder the full participation of children with disabilities. -[](src/media/commacc-part-3_recommendations_fr.docx) - ![communication access symbol](/media/commaccsymbol.png) [Learn about the communication access symbol (c)](https://www.cdacanada.com/resources/accessible-businesses-and-services/communication-access-symbol/) diff --git a/src/projects/en-CA/future-of-work-equitable-digital-systems.md b/src/projects/en-CA/future-of-work-equitable-digital-systems.md index fab5de10..2ec5781a 100644 --- a/src/projects/en-CA/future-of-work-equitable-digital-systems.md +++ b/src/projects/en-CA/future-of-work-equitable-digital-systems.md @@ -47,7 +47,7 @@ Our first co-design captured moments (vignettes) that illustrate some of the exp {% endimagePositionWithText %} -#### [](/media/experience.docx)Download Samples from Co-design 1 +#### Download Samples from Co-design 1 [Experiences with Technology in English](/media/experience.docx) @@ -59,13 +59,14 @@ The second and fourth EDS co-designs brought contributors together to create "St #### Jumper Gets a Job - + #### Jessica looks for Job -https://www.youtube.com/watch?v=EVuTl2PG0O8[](https://www.youtube.com/watch?v=EVuTl2PG0O8) + + @@ -122,9 +123,7 @@ For another co-design set, teams of co-designers wrote letters to technology. Th > > *I have many hopes for our future together. I want to reach higher in my professional life and find a position where I can fully utilize my talents, skills and experience, with fewer communication barriers than ever before. I want to participate more fully in my community. I want to show the world that deaf, hard of hearing and deaf-blind people are everywhere, we are competent and capable, and we deserve the same access and opportunities as everyone else. My hope is that you continually improve yourself so that you can help me and others with hearing loss connect with anyone, anywhere. Zoom Live Transcription, I adore you!* -[](/media/the-letters.docx) - -#### [](/media/the-letters.docx)Break-up Letter +#### Break-up Letter > *Dear Zoom Live Transcription,* > @@ -144,7 +143,7 @@ For another co-design set, teams of co-designers wrote letters to technology. Th > > *Regretfully,* -#### [](/media/the-letters.docx)Compromise Letter +#### Compromise Letter > *Dear Zoom, Live Transcription,* > @@ -158,14 +157,12 @@ For another co-design set, teams of co-designers wrote letters to technology. Th > > *With love and gratitude,* -### [](/media/the-letters.docx)Download all of the Letters +### Download all of the Letters [Letters to Technology in English](/media/the-letters.docx) [Lettres à la technologie en français](/media/les_lettres.docx) -[](/media/experience.docx) - ## Partners ![Logos for each of the partners listed below who contributed to the project.](/media/partners_eds.png) @@ -274,4 +271,4 @@ Cheryl Zinyk This project was funded by **Accessibility Standards Canada** -![The logo of the Government of Canada.](/media/canada.png) \ No newline at end of file +![The logo of the Government of Canada.](/media/canada.png) diff --git a/src/projects/en-CA/odd.md b/src/projects/en-CA/odd.md index e9f0085e..7f7c0a7b 100644 --- a/src/projects/en-CA/odd.md +++ b/src/projects/en-CA/odd.md @@ -13,7 +13,7 @@ IDRC with the support of Kessler Foundation and Microsoft has launched ODD (Opti ## About -In the work with did in our [We Count project ](https://wecount.inclusivedesign.ca/)and [Future of Work and Disability project](https://wecount.inclusivedesign.ca/views/fwd/) we noticed that AI hiring tools were filtering out highly qualified candidates with disabilities. It is estimated that over 50% of companies will deploy some form of AI assisted or AI automated hiring tools in the next decade (Sage, Pego). We knew that AI hiring tools exploit data regarding past hiring to filter applicants by optimizing the characteristics of past successes. In optimizing past successes these tools are biased against diversification; while the companies deploying them have a commitment to diversity, equity, and inclusion. AI hiring tool options such as specifying “culture fit,” persona matching, team profiles, and favourite university, contribute toward creating a company monoculture. This is not good for company survival. It also filters out applicants with disabilities. Promising research has shown that algorithms that favour data exploration rather than data exploitation result in greater hiring diversity without compromising hiring success [](<(https://www.nber.org/papers/w27736>)([Hiring as Exploration](https://www.nber.org/papers/w27736)). This prior research focuses on race, origin, and gender diversity. ODD will extend this research to the more difficult area of disability. Unlike race, origin, and gender; disability has no common data characteristic other than distance from the average so that things made for the mainstream don’t work for you. +In the work with did in our [We Count project ](https://wecount.inclusivedesign.ca/)and [Future of Work and Disability project](https://wecount.inclusivedesign.ca/views/fwd/) we noticed that AI hiring tools were filtering out highly qualified candidates with disabilities. It is estimated that over 50% of companies will deploy some form of AI assisted or AI automated hiring tools in the next decade (Sage, Pego). We knew that AI hiring tools exploit data regarding past hiring to filter applicants by optimizing the characteristics of past successes. In optimizing past successes these tools are biased against diversification; while the companies deploying them have a commitment to diversity, equity, and inclusion. AI hiring tool options such as specifying “culture fit,” persona matching, team profiles, and favourite university, contribute toward creating a company monoculture. This is not good for company survival. It also filters out applicants with disabilities. Promising research has shown that algorithms that favour data exploration rather than data exploitation result in greater hiring diversity without compromising hiring success ([Hiring as Exploration](https://www.nber.org/papers/w27736)). This prior research focuses on race, origin, and gender diversity. ODD will extend this research to the more difficult area of disability. Unlike race, origin, and gender; disability has no common data characteristic other than distance from the average so that things made for the mainstream don’t work for you. #### Why ODD? From 2f87ced9ac40c80dd4a20495f592d9af614911b6 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 12:34:02 -0300 Subject: [PATCH 06/12] chore: resolve further content issues --- .../en-CA/future-of-work-equitable-digital-systems.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/projects/en-CA/future-of-work-equitable-digital-systems.md b/src/projects/en-CA/future-of-work-equitable-digital-systems.md index 2ec5781a..4f8be9f6 100644 --- a/src/projects/en-CA/future-of-work-equitable-digital-systems.md +++ b/src/projects/en-CA/future-of-work-equitable-digital-systems.md @@ -59,16 +59,15 @@ The second and fourth EDS co-designs brought contributors together to create "St #### Jumper Gets a Job - + - + #### Jessica looks for Job - - + - + #### Friendship Chronicle From c9c8b121ea629d57bdc224d7ba9d1639ac25927d Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 12:57:42 -0300 Subject: [PATCH 07/12] feat: hover, focus, and active style improvements --- src/assets/styles/base/_base.scss | 36 +++++++++++++++++++++++++----- src/assets/styles/pages/_home.scss | 4 ++++ 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index 76bef24c..fc1ed140 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -28,13 +28,39 @@ a { text-decoration: underline; } -a:hover, -a:focus { - background: var(--fl-linkColor, var(--accent, var(--yellow-500))); - color: var(--fl-bgColor, currentColor); - outline: none; +main, +footer { + a { + border-radius: 5px; + } + + a:hover, + a:focus, + a:active { + outline-style: solid; + outline-width: 4px; + } + + a:hover { + color: var(--fl-bgColor, currentColor); + background: var(--fl-linkColor, var(--accent, var(--yellow-500))) !important; + outline-color: var(--fl-linkColor, var(--accent, var(--yellow-500))); + } + + a:focus { + outline-color: var(--fl-linkColor, var(--indigo-800)); + outline-offset: 2px; + outline-width: 2px; + } + + a:active { + color: var(--fl-bgColor, var(--white)); + background: var(--fl-linkColor, var(--indigo-800)); + outline-color: var(--fl-linkColor, var(--indigo-800)); + } } + a[hreflang], a[download], a[rel='external'] { diff --git a/src/assets/styles/pages/_home.scss b/src/assets/styles/pages/_home.scss index 069ef1ab..71030835 100755 --- a/src/assets/styles/pages/_home.scss +++ b/src/assets/styles/pages/_home.scss @@ -35,6 +35,10 @@ } } +#what-is-inclusive-design + * { + z-index: 1; +} + .page--home .entry + .entry { margin-top: rem(24); } From 5178f05a36cad24db7d49bec89833429dfb45d53 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 13:07:08 -0300 Subject: [PATCH 08/12] fix: resolve linting error --- src/assets/styles/base/_base.scss | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index fc1ed140..af7ff80c 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -33,7 +33,7 @@ footer { a { border-radius: 5px; } - + a:hover, a:focus, a:active { @@ -42,8 +42,8 @@ footer { } a:hover { - color: var(--fl-bgColor, currentColor); background: var(--fl-linkColor, var(--accent, var(--yellow-500))) !important; + color: var(--fl-bgColor, currentColor); outline-color: var(--fl-linkColor, var(--accent, var(--yellow-500))); } @@ -54,13 +54,12 @@ footer { } a:active { - color: var(--fl-bgColor, var(--white)); background: var(--fl-linkColor, var(--indigo-800)); + color: var(--fl-bgColor, var(--white)); outline-color: var(--fl-linkColor, var(--indigo-800)); } } - a[hreflang], a[download], a[rel='external'] { From 00514f146728589c1d84cbfdd0ae6c332d964748 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 13:11:17 -0300 Subject: [PATCH 09/12] fix: resolve issues with secondary nav --- src/assets/styles/base/_base.scss | 2 +- src/assets/styles/components/_nav--secondary.scss | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index af7ff80c..3ec6121f 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -42,7 +42,7 @@ footer { } a:hover { - background: var(--fl-linkColor, var(--accent, var(--yellow-500))) !important; + background: var(--fl-linkColor, var(--accent, var(--yellow-500))); color: var(--fl-bgColor, currentColor); outline-color: var(--fl-linkColor, var(--accent, var(--yellow-500))); } diff --git a/src/assets/styles/components/_nav--secondary.scss b/src/assets/styles/components/_nav--secondary.scss index 92eb1c3b..d9fcffd6 100644 --- a/src/assets/styles/components/_nav--secondary.scss +++ b/src/assets/styles/components/_nav--secondary.scss @@ -14,6 +14,7 @@ .menu--secondary a { align-items: center; + border-radius: 0; border-bottom: rem(1) solid var(--fl-linkColor, var(--black)); display: block; display: flex; @@ -30,6 +31,7 @@ calc(-1 * var(--gutter)) rem(-1) 0 rem(1) var(--fl-linkColor, var(--indigo-800)), var(--gutter) rem(-1) 0 rem(1) var(--fl-linkColor, var(--indigo-800)); color: var(--fl-bgColor, var(--white)); + outline: transparent; } &:active { @@ -37,7 +39,8 @@ box-shadow: calc(-1 * var(--gutter)) rem(-1) 0 rem(1) var(--fl-linkColor, var(--indigo-500)), var(--gutter) rem(-1) 0 rem(1) var(--fl-linkColor, var(--indigo-500)); - color: var(--fl-bgColor); + color: var(--fl-bgColor, var(--white)); + outline: transparent; } &::after { From d4fa7caa6b73c3fbb09c2efadf0e32059a0fda0a Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 13:11:30 -0300 Subject: [PATCH 10/12] fix: resolve linting error --- src/assets/styles/components/_nav--secondary.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/assets/styles/components/_nav--secondary.scss b/src/assets/styles/components/_nav--secondary.scss index d9fcffd6..c4947d0d 100644 --- a/src/assets/styles/components/_nav--secondary.scss +++ b/src/assets/styles/components/_nav--secondary.scss @@ -14,8 +14,8 @@ .menu--secondary a { align-items: center; - border-radius: 0; border-bottom: rem(1) solid var(--fl-linkColor, var(--black)); + border-radius: 0; display: block; display: flex; flex-direction: row; From ff8050983bdd5f465488c5313ab3204b0b8a1697 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 15:11:41 -0300 Subject: [PATCH 11/12] fix: remove unnecessary SVG margin --- src/assets/styles/base/_base.scss | 10 ++++++++-- src/transforms/parse.js | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index 3ec6121f..e3c686e6 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -65,10 +65,16 @@ a[download], a[rel='external'] { svg { display: inline-block; - margin-left: 0.25em; - margin-right: 0.25em; width: 1em; } + + svg:first-child { + margin-right: 0.25em; + } + + svg:last-child { + margin-left: 0.25em; + } } a[hreflang] { diff --git a/src/transforms/parse.js b/src/transforms/parse.js index c2570c7f..3e281f8c 100644 --- a/src/transforms/parse.js +++ b/src/transforms/parse.js @@ -43,7 +43,7 @@ module.exports = (value, outputPath) => { ) { link.setAttribute('rel', 'external'); if (!link.closest('nav') && link.className !== 'project__link') { - link.innerHTML = `${link.innerHTML}`; + link.innerHTML = `${link.innerHTML}`; } } @@ -51,7 +51,7 @@ module.exports = (value, outputPath) => { link.href.endsWith('.docx') || link.href.endsWith('.pdf') ) { link.setAttribute('download', ''); - link.innerHTML = `${link.innerHTML}`; + link.innerHTML = `${link.innerHTML}`; } } } From 2ce8e26164644e45ddaabbf4ffdd36ec38d8072b Mon Sep 17 00:00:00 2001 From: Ned Zimmerman Date: Wed, 21 Jun 2023 15:13:03 -0300 Subject: [PATCH 12/12] fix: resolve linting issue --- src/assets/styles/base/_base.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/assets/styles/base/_base.scss b/src/assets/styles/base/_base.scss index e3c686e6..58a56407 100755 --- a/src/assets/styles/base/_base.scss +++ b/src/assets/styles/base/_base.scss @@ -67,7 +67,7 @@ a[rel='external'] { display: inline-block; width: 1em; } - + svg:first-child { margin-right: 0.25em; }