Fix eleventy start command #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for idrc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
greatislander
requested changes
Jun 21, 2023
package.json
Outdated
| @@ -9,6 +9,7 @@ | |||
| "backstop:test:ci": "backstop test --config=backstop.config.js", | |||
| "backstop:approve": "backstop approve --config=backstop.config.js", | |||
| "build": "npm-run-all -l clean build:*", | |||
| "build-cms": "node ./build-cms.js -w", | |||
There was a problem hiding this comment.
I think this is a bit confusing because we have a build:cms script too, and all the build:* commands are for building the site, not running in dev mode. How about you change this to cms and then change cms to proxy?
There was a problem hiding this comment.
Yep, that makes sense; thanks for the suggestion.
package.json
Outdated
| @@ -24,7 +25,7 @@ | |||
| "test": "run-s test:*", | |||
| "start": "npm-run-all -l clean -p start:*", | |||
| "start:webpack": "mix watch", | |||
| "start:eleventy": "run-p dev cms", | |||
| "start:eleventy": "run-p dev build-cms cms", | |||
There was a problem hiding this comment.
Suggested change
| "start:eleventy": "run-p dev build-cms cms", | |
| "start:eleventy": "run-p dev cms proxy", |
greatislander
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run testwithout errorsnpm run buildwithout errorsDescription
Eleventy start command has updated on this commit: 9ebe519 and build-cms script was omitted by an accident. Add back build-cms script with eleventy start command.