Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve header styling on home page #641

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

greatislander
Copy link
Member

  • This pull request has been tested by running npm run test without errors
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

Currently, the site homepage has an issue where the nav bar colour is not the same as the UIO prefs panel colour, leading to an unexpected effect:

Screenshot 2023-06-22 at 10 29 51 AM

This PR resolves the issue:

Screenshot 2023-06-22 at 10 30 47 AM

Steps to test

  1. npm start
  2. Visit the homepage.

Expected behavior: UIO bar area and primary nav have the same background colour.

Additional information

The other pages with different nav bar colours were already working as expected (see, for example, Projects).

Related issues

Not applicable.

@greatislander greatislander added the bug Something isn't working label Jun 22, 2023
@greatislander greatislander self-assigned this Jun 22, 2023
@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for idrc ready!

Name Link
🔨 Latest commit d9ac624
🔍 Latest deploy log https://app.netlify.com/sites/idrc/deploys/649454b61d10c300079d284b
😎 Deploy Preview https://deploy-preview-641--idrc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/assets/styles/vendors/_uio.scss Outdated Show resolved Hide resolved
@greatislander greatislander requested a review from jhung June 22, 2023 14:03
@greatislander greatislander merged commit 71857ff into dev Jun 22, 2023
7 checks passed
@greatislander greatislander deleted the fix/header-styling branch June 22, 2023 14:08
@greatislander greatislander added this to the 2.0.0 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants