Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear All" links show for all sections regardless of selection #814

Open
BlueSlug opened this issue Dec 2, 2021 · 0 comments
Open

"Clear All" links show for all sections regardless of selection #814

BlueSlug opened this issue Dec 2, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@BlueSlug
Copy link
Contributor

BlueSlug commented Dec 2, 2021

Describe the bug

On the Resources page, regardless of how many and which filter sections actually have a selection, the "Clear all ..." link for each section is shown. It would be better to show "clear all" links only when a checkbox in a given section is checked.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Resources page
  2. Click on a Topic checkbox and wait for the page to reload
  3. See error

Expected behavior

The link should appear only when a given filter section has a checkbox selected (i.e. checked).

E.g. "Clear All Topics" should only appear if at least one Topic is selected.

Screenshots

014

Additional context

The Figma design for the Resources page specifies the expected behaviour.

@BlueSlug BlueSlug added the bug Something isn't working label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant