Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nouvel Iframe de simulation #1302

Merged
merged 19 commits into from
Sep 14, 2023
Merged

Nouvel Iframe de simulation #1302

merged 19 commits into from
Sep 14, 2023

Conversation

Clemog
Copy link
Contributor

@Clemog Clemog commented Sep 13, 2023

Suite au travail mené dans incubateur-ademe/nosgestesclimat#1872, l'idée ici est de proposer une solution d'intégration du site dans un site intégrateur qui porte la responsabilité d'un modèle régionalisé dans un site "vitrine".

On peut prendre ici l'exemple de https://nosgestesclimat.ch pour la suisse donc.

En bref, via le script de l'iframe, on a 2 nouvelles options.

L'option "data-localisation" qui permet de fixer la localisation pour charger le modèle voulu. Le bandeau de localisation et la détection auto sont alors désactivés.

L'option "data-only-simulation" qui permet de faire disparaitre le Footer NGC pour mettre en valeur celui du site intégrateur et la disparition de la redirection vers la home NGC via le logo. Un autre élément important, on affiche non plus la Landing NGC mais directement le test (et donc le tuto). A voir si c'est optimal, on pourra itérer rapidement :).

Pour le script en question :

<script
	id="nosgestesclimat"
	src="/iframeSimulation.js"
	data-only-simulation="true"
	data-localisation="CH"
        data-PR="1872"
></script>

Démo : https://deploy-preview-1302--nosgestesclimat.netlify.app/demo-iframesimulation

  • Vérifier que tout fonctionne si localisation non fonctionnelle
  • Traduction

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Report for the pull request #1302


🌐 Translation status

UI's texts

Language Nb. missing translations Status
en-us Ø ✔️

FAQ's questions

Language Nb. missing translations Status
en-us Ø ✔️

You will find more information about the translation in the dedicated file.

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for nosgestesclimat ready!

Name Link
🔨 Latest commit 9514d88
🔍 Latest deploy log https://app.netlify.com/sites/nosgestesclimat/deploys/65032805f82bce0007101f4b
😎 Deploy Preview https://deploy-preview-1302--nosgestesclimat.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🔴 down 1 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 89 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Clemog Clemog force-pushed the iframe-resizing branch 2 times, most recently from 4f55915 to 4fe3cd1 Compare September 14, 2023 07:29
@Clemog Clemog requested a review from bjlaa September 14, 2023 08:52
source/components/Logo.tsx Outdated Show resolved Hide resolved
@Clemog Clemog merged commit 20fb496 into master Sep 14, 2023
@Clemog Clemog deleted the iframe-resizing branch September 14, 2023 15:44
@Clemog Clemog restored the iframe-resizing branch September 14, 2023 16:00
Clemog added a commit that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants