Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilise la version upgradé du modèle #1419

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Utilise la version upgradé du modèle #1419

merged 7 commits into from
Nov 2, 2023

Conversation

Clemog
Copy link
Contributor

@Clemog Clemog commented Oct 11, 2023 •
edited by EmileRolley
Loading

Pour tester les branches du modèle issues de preprod avant la refonte sur l'ancienne interface

Demo : https://deploy-preview-1419--nosgestesclimat.netlify.app/simulateur/bilan?PR=2143

@Clemog Clemog changed the title fix: supprime exceptions modèle Test preprod modèle Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Report for the pull request #1419

🌐 Translation status

UI's texts

Language Nb. missing translations Status
en Ø ✔️

FAQ's questions

Language Nb. missing translations Status
en Ø ✔️

You will find more information about the translation in the dedicated file.

@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for nosgestesclimat ready!

Name Link
🔨 Latest commit 1ec65bb
🔍 Latest deploy log https://app.netlify.com/sites/nosgestesclimat/deploys/6543bcd0fc578200081cc658
😎 Deploy Preview https://deploy-preview-1419--nosgestesclimat.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 65 (🔴 down 6 from production)
Accessibility: 90 (no change from production)
Best Practices: 83 (no change from production)
SEO: 89 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@notion-workspace
Copy link

Intégration des 5 landing pages Brevo

EmileRolley
EmileRolley reviewed Nov 2, 2023
View reviewed changes
source/pages/groupe-dashboard/components/VotreEmpreinte.tsx Outdated
@@ -10,7 +10,7 @@ const EMOJI_TEXT_MAP: {
text: string
}
} = {
'transport . empreinte': {
transport: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: on n'a pas besoin de EMOJI_TEXT_MAP non ? On peut récupérer l'info directement depuis les règles du modèle. @florianpanchout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'avoue que je n'ai pas regarder en détail d'ou provenait les erreurs mais effectivement cette variable ne semble pas utile, je ne comprends pas trop quelle était son utilité ? C'était pour le mode challenge non @bjlaa ? Ce n'est plus utilisé dans le site next ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En fait on l'a toujours : https://github.com/incubateur-ademe/nosgestesclimat-site-nextjs/blob/main/src/app/(layout-with-navigation)/(simulation)/amis/resultats/_components/VotreEmpreinte.tsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je suis assez surpris..
Notamment par le changement de titre entre services sociétaux et services publics ?? Les services publics sont dans les services sociétaux

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En fait on l'a toujours : https://github.com/incubateur-ademe/nosgestesclimat-site-nextjs/blob/main/src/app/(layout-with-navigation)/(simulation)/amis/resultats/_components/VotreEmpreinte.tsx

A oui bien vu, il faudra penser à le modifier sur la version Next.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai fait une suggestion notion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprè§s il me semble que personne ne devrait arriver ici pour le mode "Amis", c'est uniqumeent pour "sondage"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah oui non ça ne sert plus à rien

@EmileRolley EmileRolley force-pushed the test-preprod-model branch 5 times, most recently from 7302b7d to 7b4e196 Compare November 2, 2023 12:01
@EmileRolley EmileRolley force-pushed the test-preprod-model branch 2 times, most recently from ac3acac to 81552ad Compare November 2, 2023 12:27
@EmileRolley EmileRolley mentioned this pull request Nov 2, 2023
Merged
@Clemog Clemog changed the title Test preprod modèle Utilise la version upgradé du modèle Nov 2, 2023
@Clemog Clemog merged commit 6cfd5ab into master Nov 2, 2023
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmileRolley EmileRolley EmileRolley left review comments

@bjlaa bjlaa bjlaa left review comments

@florianpanchout florianpanchout Awaiting requested review from florianpanchout

Assignees
No one assigned
Labels
tech
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clemog @bjlaa @EmileRolley