Skip to content

Commit

Permalink
fix todo
Browse files Browse the repository at this point in the history
  • Loading branch information
longquanzheng committed Mar 9, 2024
1 parent e76b330 commit bd4c00f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions service/api/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,12 @@ func (s *serviceImpl) ApiV1WorkflowWaitForStateCompletion(
TaskQueue: s.taskQueue,
// TODO: https://github.com/indeedeng/iwf-java-sdk/issues/218
// it doesn't seem to have a way for SDK to know the timeout at this API
// So hardcoded to 1 minute for now. If it timeouts, the IDReusePolicy will restart a new one
WorkflowExecutionTimeout: 60 * time.Second,
// So hardcoded to 1 hour for now. If it timeouts, the IDReusePolicy will restart a new one
WorkflowExecutionTimeout: 60 * time.Minute,
}

runId, err := s.client.StartWaitForStateCompletionWorkflow(ctx, options)
if err != nil {
// TODO fix error handling so that this API can be called again to wait for multiple times
return nil, s.handleError(err)
}

Expand Down

0 comments on commit bd4c00f

Please sign in to comment.