Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support timer duration as preference over firingTimestamp for timerCommand #393

Merged
merged 10 commits into from
May 30, 2024
Merged

Support timer duration as preference over firingTimestamp for timerCommand #393

merged 10 commits into from
May 30, 2024

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented May 30, 2024 •
edited
Loading

Screenshot 2024-05-30 at 2 44 46 PM

@longquanzheng
Update idl to use timerDuration
f0b8b56
@longquanzheng
done
f9d105d 
fix and add tests

add log

fix buiold

add comment

revert impl
@longquanzheng
done
0d16c5e
@longquanzheng
refactor
90033e4
@longquanzheng longquanzheng mentioned this pull request May 30, 2024
Closed
mattschlitz
mattschlitz reviewed May 30, 2024
View reviewed changes
service/interpreter/timerProcessor.go Outdated
timerCommands = append(timerCommands, iwfidl.TimerCommand{
CommandId: cmd.CommandId,
FiringUnixTimestampSeconds: cmd.FiringUnixTimestampSeconds,
})
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's a technical reason for this but why don't we just append the original cmd here (like timerCommands = append(timerCommands, cmd))?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that's simpler to do that. Thanks for pointing it out :D

@longquanzheng longquanzheng merged commit 5728047 into main May 30, 2024
5 checks passed
@longquanzheng longquanzheng changed the title Use timer duration to replace firingTimestamp for timerCommand Support timer duration as preference over firingTimestamp for timerCommand Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattschlitz mattschlitz mattschlitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longquanzheng @mattschlitz