Discussion for InDepth Guide for Creating Nested and Reusable Forms

[shhdharmen]

Discussion for InDepth Guide for Creating Nested and Reusable Forms

[acuevas91]

Great article! I found it very useful and handy!

I have just one doubt about, which component would have the responsibility if the address would have an autocomplete to populate the form or it would have to retrieve the countries from a service?

Shoud these requests have been done in the reusable address component if you wanna reuse it in other part? Or this logic should be part of a smart parent component and work with input/ouput?

Many thanks for the article!!

[shhdharmen]

Thanks for your feedback. Having countries in parent vs shared component depends on your use case. To achieve complete reusability I think it should be part of shared component it self. Thanks, Dharmen Shah

…

On Thu, 29 Sept, 2022, 5:37 pm Alejandro Cuevas Álvarez, < ***@***.***> wrote: Great article! I found it very useful and handy! I have just one doubt about, which component would have the responsibility if the address would have an autocomplete to populate the form or it would have to retrieve the countries from a service? Shoud these requests have been done in the reusable address component if you wanna reuse it in other part? Or this logic should be part of a smart parent component and work with input/ouput? Many thanks for the article!! — Reply to this email directly, view it on GitHub <#280 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUDZM7ALBA7DK225D5R5ADWAWBADANCNFSM57A5QRWQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[acuevas91]

Thanks for your response! i agree with you, because it would be fully reusable.

It would be like a smart component inside in another smart component right? This is a complex layout, not a typical one, as you mention it depends on the case.

[shhdharmen]

I am not sure what do you mean by smart component.

…

On Thu, 29 Sept, 2022, 7:30 pm Alejandro Cuevas Álvarez, < ***@***.***> wrote: Thanks for your response! i agree with you, because it would be fully reusable. It would be like a smart component inside in another smart component right? This is a complex layout, not a typical one, as you mention it depends on the case. — Reply to this email directly, view it on GitHub <#280 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUDZM3VHRKEC27PRSNLQ2LWAWOI5ANCNFSM57A5QRWQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[acuevas91]

IMO, smart component is a component (aka container component, page component...) with some logic or connection between different services like Store, UserService, AutocompleteAddressService... (i.e UserPageComponent, UserComponent, AddressFormComponent...) in contrast with dumb component which is is a simple component with input and outputs, no more than display logic (i.e Input, Checkbox, Dropdown...)

I do not know if I explained well.

[pcoombe]

Ive been looking for a ng14 ControlValueAccessor example for the last week.

finally looks like i might have the answers to our typed forms migrations!

[kumar-tadepalli]

Great Article.
But the Stackblitz link is not working.

[shhdharmen]

Stack Blitz works directly from GitHub repo.

See if you can run the repo locally
https://github.com/shhdharmen/nested-reusable-form