Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend API Refinements #351

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Backend API Refinements #351

merged 3 commits into from
Jul 10, 2024

Conversation

pulsipher
Copy link
Collaborator

This is a continuation of #349 . This comprises a number of refinements to the transformation API as motivated by InfiniteExaModels. Improvements include:

  • A reduction in the methods that need to be extended for queries
  • The addition of JuMP.is_solved_and_feasible
  • Sanity checks to make sure results aren't queried with an out-of-date model
  • Added public API functions that are helpful for extensions (i.e., parameter_group_indices, parameter_refs(::InfiniteModel), parameter_group_int_index, all_expression_variables, core_object)
  • Change of nomenclature from "object numbers" to "infinite parameter group integer indices".
  • Code base simplifications

@pulsipher pulsipher added enhancement New feature or request breaking This will introduce breaking changes to the API simplification Simplify the underlying complexity transformations Something to do with model transformations labels Jul 9, 2024
@pulsipher pulsipher added this to the v0.6 milestone Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (db449cc) to head (179a077).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          35       35           
  Lines        6712     6758   +46     
=======================================
+ Hits         6697     6743   +46     
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulsipher pulsipher merged commit e92a60b into master Jul 10, 2024
10 checks passed
@pulsipher pulsipher deleted the backend_refinements branch July 10, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This will introduce breaking changes to the API enhancement New feature or request simplification Simplify the underlying complexity transformations Something to do with model transformations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant