Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Transformation API #248

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Refactor Transformation API #248

wants to merge 15 commits into from

Conversation

pulsipher
Copy link
Collaborator

@pulsipher pulsipher commented Mar 4, 2022

This seeks to address #105. This constitutes a large undertaking and will take sometime to get right. Once completed, it should open the way up to resolve many of the existing issues.

@pulsipher pulsipher added breaking This will introduce breaking changes to the API simplification Simplify the underlying complexity transformations Something to do with model transformations labels Mar 4, 2022
@pulsipher pulsipher self-assigned this Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #248 (7637c4b) into master (ba79f48) will decrease coverage by 99.78%.
The diff coverage is 0.00%.

❗ Current head 7637c4b differs from pull request most recent head 562257d. Consider uploading reports for the commit 562257d to get more accurate results

@@            Coverage Diff             @@
##           master    #248       +/-   ##
==========================================
- Coverage   99.77%   0.00%   -99.78%     
==========================================
  Files          36      35        -1     
  Lines        7103    6783      -320     
==========================================
- Hits         7087       0     -7087     
- Misses         16    6783     +6767     
Impacted Files Coverage Δ
src/TranscriptionOpt/derivatives.jl 0.00% <0.00%> (ø)
src/TranscriptionOpt/measures.jl 0.00% <0.00%> (-100.00%) ⬇️
src/TranscriptionOpt/supports.jl 0.00% <0.00%> (ø)
src/array_parameters.jl 0.00% <0.00%> (-99.80%) ⬇️
src/constraints.jl 0.00% <0.00%> (-100.00%) ⬇️
src/datatypes.jl 0.00% <0.00%> (-100.00%) ⬇️
src/derivatives.jl 0.00% <0.00%> (-99.54%) ⬇️
src/expressions.jl 0.00% <0.00%> (-99.68%) ⬇️
src/finite_variables.jl 0.00% <0.00%> (-100.00%) ⬇️
src/general_variables.jl 0.00% <ø> (-100.00%) ⬇️
... and 14 more

... and 15 files with indirect coverage changes

@pulsipher
Copy link
Collaborator Author

Some plans on this were shared at https://www.youtube.com/watch?v=4DwpaqxAKwU

@pulsipher
Copy link
Collaborator Author

This has been partially resolved by #349. However, this PR provides some ideas on how to provide an incremental interface for transformation backend attributes that correspond to InfiniteModel objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This will introduce breaking changes to the API simplification Simplify the underlying complexity transformations Something to do with model transformations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant