Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow this to work with page caching #67

Open
MSchmidt opened this issue Jul 20, 2018 · 2 comments
Open

Allow this to work with page caching #67

MSchmidt opened this issue Jul 20, 2018 · 2 comments

Comments

@MSchmidt
Copy link

The banner is shown/hidden while rendering the page in Rails. I think it's preferable as plain javascript solution that would work with page caching or similar activated. Meaning the banner should always be rendered by rails (but set to hidden). Then we check for the cookie via javascript and unhide the banner when necessary.

@strehlst
Copy link

strehlst commented Apr 4, 2019

We unfortunately needed to step back from using this gem due to the incompatibility with page caching as stated by @MSchmidt Anything planned?

@gabskoro
Copy link
Collaborator

gabskoro commented Oct 2, 2020

We started also having some other problems with the current approach (#55 (comment)), so It makes sense to evaluate the idea, will definitely take a look, tnx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants