Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_training_name_pairs to pass additional arguments to prepare_name_pairs #29

Merged
merged 10 commits into from
Nov 15, 2024

Conversation

chrispyl
Copy link
Collaborator

@chrispyl chrispyl commented Nov 15, 2024

Background

The classes SparkEntityMatching and PandasEntityMatching have a method create_training_name_pairs which then calls either prepare_name_pairs or prepare_name_pairs_pd. The issue is that prepare_name_pairs_pd accepts parameters which are not exposed through create_training_name_pairs like drop_samename_nomatch.

Changes

  • Added kwargs to both spark and pandas versions of create_training_name_pairs to allow them to pass arguments to prepare_name_pairs_pd
  • Some formatting changed by ruff.

@mbaak mbaak merged commit 1a11ae3 into ing-bank:main Nov 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants