bump wasmvm to latest #74
Conversation
WalkthroughThe pull request introduces updates to both the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
Dockerfile (1)
Line range hint
26-27: Consider documenting architecture-specific details.The library downloads support both aarch64 and x86_64 architectures. Consider adding a comment explaining the architecture selection process during build.
Add documentation like:
ADD https://github.com/CosmWasm/wasmvm/releases/download/${LIBWASMVM_VERSION}/libwasmvm_muslc.aarch64.a /lib/libwasmvm_muslc.aarch64.a ADD https://github.com/CosmWasm/wasmvm/releases/download/${LIBWASMVM_VERSION}/libwasmvm_muslc.x86_64.a /lib/libwasmvm_muslc.x86_64.a +# The appropriate architecture-specific library will be selected during the build +# based on the build platform's architecture (see cp command below)go.mod (1)
Line range hint
284-297: LGTM! Consider tracking temporary replacements.The replace directives are well-documented with clear explanations for each custom fork or version pin. The use of specific commit hashes ensures reproducible builds.
Consider:
- Creating issues to track the temporary replacements, especially for:
- cometbft-client: Once PR fix: bridge hook to check sender addr #10 is merged
- grpc: When the relayer issue is resolved
- Setting up automated dependency update checks to notify when upstream changes are available
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
- Dockerfile (1 hunks)
- go.mod (1 hunks)
🔇 Additional comments (3)
Dockerfile (2)
Line range hint
28-29: Enable hash verification for security.The commented hash verification lines should be uncommented and updated with the correct hashes for v2.1.3 to ensure library integrity.
[security]Let's fetch the correct hashes for v2.1.3:
✅ Verification successful
Update hash verification lines with correct values for v2.1.3
The commented lines should be uncommented and updated with the following hashes:
- For aarch64:
faea4e15390e046d2ca8441c21a88dba56f9a0363f92c5d94015df0ac6da1f2d- For x86_64:
8dab08434a5fe57a6fbbcb8041794bc3c31846d31f8ff5fb353ee74e0fcd3093Replace the existing lines with:
RUN sha256sum /lib/libwasmvm_muslc.aarch64.a | grep faea4e15390e046d2ca8441c21a88dba56f9a0363f92c5d94015df0ac6da1f2d RUN sha256sum /lib/libwasmvm_muslc.x86_64.a | grep 8dab08434a5fe57a6fbbcb8041794bc3c31846d31f8ff5fb353ee74e0fcd3093🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Get correct hashes for v2.1.3 libraries curl -sL https://github.com/CosmWasm/wasmvm/releases/download/v2.1.3/checksums.txt | grep -E 'libwasmvm_muslc.(aarch64|x86_64).a'Length of output: 314
5-5: LGTM on version bump, but verify latest version.The version bump from v2.1.2 to v2.1.3 looks correct, matching the go.mod update.
Let's verify this is the latest version and check for any breaking changes:
go.mod (1)
19-20: LGTM! Verify Dockerfile coordination.The wasmvm dependency update from v2.1.2 to v2.1.3 looks good. The comment correctly indicates that LIBWASMVM_VERSION in Dockerfile needs to be updated as well.
Let's verify the Dockerfile update:
✅ Verification successful
Dockerfile and go.mod versions are in sync ✅
The verification confirms that LIBWASMVM_VERSION in Dockerfile is correctly set to v2.1.3, matching the wasmvm dependency version in go.mod.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that LIBWASMVM_VERSION in Dockerfile matches the go.mod version # Test: Check if Dockerfile contains the updated version rg "LIBWASMVM_VERSION.*v2\.1\.3" DockerfileLength of output: 74
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
Bug Fixes
Chores