Fix pkgresources import #7866
Closed
Fix pkgresources import #7866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderr
commented
Jul 18, 2024
| upgrade-note: "If you had previously constrained `setuptools<71` in your `pyproject.yml`, you may now drop the constraint" | ||
| destination-branches: | ||
| - master | ||
| - iso7 |
There was a problem hiding this comment.
iso6 will have its own PR because it has a second occurrence of this import.
arnaudsjs
approved these changes
Jul 18, 2024
|
@edvgui requesting your review for the changelog entries (what's in "sections" will be visible to the customers in the generated changelog for the patch release in the documentation). |
edvgui
approved these changes
Jul 18, 2024
|
@arnaudsjs I had to apply one more fix due to pypa/setuptools#4482. It's not pretty but it's the best I can think of on short notice, and we can hopefully get rid of the hack when we migrate away from |
arnaudsjs
approved these changes
Jul 18, 2024
hlloreda
approved these changes
Jul 18, 2024
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Jul 18, 2024
# Description Fixed import of `pkg_resources.extern`, which was dropped in the latest `setuptools` release (v71). # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] ~~Attached issue to pull request~~ - [x] Changelog entry - [x] ~~Type annotations are present~~ - [x] ~~Code is clear and sufficiently documented~~ - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] ~~Sufficient test cases (reproduces the bug/tests the requested feature)~~ - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [x] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
|
Merged into branches master in 2ce0148 |
inmantaci
pushed a commit
that referenced
this pull request
Jul 18, 2024
# Description Fixed import of `pkg_resources.extern`, which was dropped in the latest `setuptools` release (v71). # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] ~~Attached issue to pull request~~ - [x] Changelog entry - [x] ~~Type annotations are present~~ - [x] ~~Code is clear and sufficiently documented~~ - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] ~~Sufficient test cases (reproduces the bug/tests the requested feature)~~ - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [x] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
|
Processing #7868. |
inmantaci
pushed a commit
that referenced
this pull request
Jul 18, 2024
Pull request opened by the merge tool on behalf of #7866
inmantaci
pushed a commit
that referenced
this pull request
Jul 18, 2024
# Description Fixed import of `pkg_resources.extern`, which was dropped in the latest `setuptools` release (v71). # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] ~~Attached issue to pull request~~ - [x] Changelog entry - [x] ~~Type annotations are present~~ - [x] ~~Code is clear and sufficiently documented~~ - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] ~~Sufficient test cases (reproduces the bug/tests the requested feature)~~ - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [x] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
inmantaci
pushed a commit
that referenced
this pull request
Jul 18, 2024
# Description Fixed import of `pkg_resources.extern`, which was dropped in the latest `setuptools` release (v71). # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] ~~Attached issue to pull request~~ - [x] Changelog entry - [x] ~~Type annotations are present~~ - [x] ~~Code is clear and sufficiently documented~~ - [x] No (preventable) type errors (check using make mypy or make mypy-diff) - [x] ~~Sufficient test cases (reproduces the bug/tests the requested feature)~~ - [x] Correct, in line with design - [x] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [x] ~~If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed import of
pkg_resources.extern, which was dropped in the latestsetuptoolsrelease (v71).Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the boxAttached issue to pull requestType annotations are presentCode is clear and sufficiently documentedSufficient test cases (reproduces the bug/tests the requested feature)If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)