-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow strings as response without a wrapping tag. #241
Open
jesusabarca
wants to merge
17
commits into
inossidabile:master
Choose a base branch
from
amco:amco_cheddar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
00e8d35
Bumps up version of rails from 5.0.0 to 5.0.3 to include a bug fix in…
jesusabarca 57bd423
Merge pull request #1 from amco/fix_crashing_tests
jesusabarca 5ce8f34
Adds option for returning single strings in the response without
jesusabarca 0f61469
Merge pull request #2 from amco/adds_option_for_not_wrapping_the_resp…
jesusabarca 18f70fa
Updates the travis config file to use the gemfile for Rails 5.0.3
jesusabarca 81bc6ee
Allow a service_name configuration option with the default as 'service'.
jesusabarca 680cb2b
Renders the service name in the view.
jesusabarca 9cd0080
Adds tests for allowing a custom service name.
jesusabarca 5d03c47
Updates the README file.
jesusabarca 629cdb9
Merge pull request #3 from amco/option_to_change_the_service_name
jesusabarca 4043c38
Fixes crash
jesusabarca ea09480
adds custome tags
MtzRojas 7a53a79
Merge pull request #6 from amco/amco_cheddar_variables_tags
MtzRojas d3849e2
remove extra symbol in tag
MtzRojas 449f797
remove variable tag un envelope
MtzRojas 4731592
return default response as Response
GerardoHernandezG 411fae7
Merge pull request #7 from amco/amco_cheddar_response_tag
GerardoHernandezG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,4 +17,4 @@ gem "simplecov-summary" | |
gem "rails", "4.0.0" | ||
gem "listen", "< 3.1.0" | ||
|
||
gemspec :path => "../" | ||
gemspec path: "../" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,4 +17,4 @@ gem "simplecov-summary" | |
gem "rails", "4.1.0" | ||
gem "listen", "< 3.1.0" | ||
|
||
gemspec :path => "../" | ||
gemspec path: "../" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,4 +17,4 @@ gem "simplecov-summary" | |
gem "rails", "4.2.0" | ||
gem "listen", "< 3.1.0" | ||
|
||
gemspec :path => "../" | ||
gemspec path: "../" |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumps up version of rails from 5.0.0 to 5.0.3 to include a bug fix in the minitest plugin rails/rails#29022. This only prevents the test suit from crashing. This PR will fix this #238, so it's just a temporal fix.