Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ATL-7040 remove old did based authentication #842

Conversation

EzequielPostan
Copy link
Contributor

@EzequielPostan EzequielPostan commented May 1, 2024

Overview

This PR should be merged after merging #841 . The base branch is the branch of that PR
I suggest not to review until that PR is merged

Screenshots

Checklists

Pre-submit checklist:

  • Self-reviewed the diff
  • New code has proper comments/documentation/tests
  • Any changes not covered by tests have been tested manually
  • The README files are updated
  • If new libraries are included, they have licenses compatible with our project
  • If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

  • Commits have useful messages
  • Review clarifications made it into the code

This commit removes the uses of the old SDK and update tests
This commit re-organizes and renames methods for better use
This commit removes the last dependencies on the old SDK
This commit deletes the legacy DID based authentication
Copy link

github-actions bot commented May 1, 2024

Unit Test Results

276 tests   275 ✔️  24s ⏱️
  35 suites      1 💤
  35 files        0

Results for commit 21785f2.

@atala-dev
Copy link
Contributor

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors
✅ ACTION actionlint 1 0
⚠️ MARKDOWN markdownlint 5 90
⚠️ MARKDOWN markdown-link-check 5 10
✅ MARKDOWN markdown-table-formatter 5 0
⚠️ PROTOBUF protolint 4 4
✅ REPOSITORY dustilock yes no
✅ REPOSITORY git_diff yes no
✅ REPOSITORY grype yes no
⚠️ REPOSITORY kics yes 49
✅ REPOSITORY syft yes no
✅ REPOSITORY trivy-sbom yes no
⚠️ REPOSITORY trufflehog yes 1
✅ SQL sql-lint 2 0
⚠️ YAML prettier 2 1
✅ YAML v8r 2 0
✅ YAML yamllint 2 0

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@EzequielPostan
Copy link
Contributor Author

replaced with #843 after a rebase/squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants