Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ATL-7315): Replace docker library for tests #865

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

EzequielPostan
Copy link
Contributor

@EzequielPostan EzequielPostan commented Jul 3, 2024

This PR replaces the old docker-it-scala library with test-containers library, fixing the incompatibility issues with docker server 26.1.3

This PR adds the dependency on the testcontainers-scala library under MIT license (see https://github.com/testcontainers/testcontainers-scala?tab=MIT-1-ov-file#readme)

It also removes the dependencies on docker-it-scala, which was dependent on spotify's docker client library that was the root of the CI issue

Overview

Screenshots

Checklists

Pre-submit checklist:

  • Self-reviewed the diff
  • New code has proper comments/documentation/tests
  • Any changes not covered by tests have been tested manually
  • The README files are updated
  • If new libraries are included, they have licenses compatible with our project
  • If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

  • Commits have useful messages
  • Review clarifications made it into the code

@EzequielPostan EzequielPostan requested review from womfoo and shotexa July 3, 2024 20:04
@EzequielPostan EzequielPostan changed the title ATL-7315: Replace docker library for tests fix(ATL-7315): Replace docker library for tests Jul 3, 2024
@Dale-iohk
Copy link

Dale-iohk commented Jul 3, 2024

Logo
Checkmarx One – Scan Summary & Detailsbbb5dfe8-2c77-410e-92d4-9d5c9a51c27a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2024-29415 Npm-ip-2.0.0 Vulnerable Package

@atala-dev
Copy link
Contributor

atala-dev commented Jul 3, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors
✅ ACTION actionlint 1 0
✅ REPOSITORY dustilock yes no
✅ REPOSITORY git_diff yes no
⚠️ REPOSITORY kics yes 1
✅ REPOSITORY syft yes no
✅ YAML prettier 1 0
✅ YAML v8r 1 0
✅ YAML yamllint 1 0

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@EzequielPostan EzequielPostan marked this pull request as ready for review July 3, 2024 20:19
@EzequielPostan EzequielPostan force-pushed the fix-docker-library-failure-in-ci branch from c9f944d to 51d113a Compare July 3, 2024 20:51
Copy link

github-actions bot commented Jul 3, 2024

Unit Test Results

288 tests  +288   288 ✔️ +288   22s ⏱️ +22s
  36 suites +  36       0 💤 ±    0 
  36 files   +  36       0 ±    0 

Results for commit 6ebb73d. ± Comparison against base commit 7bf57d9.

♻️ This comment has been updated with latest results.

This commit replaces the old docker-it-scala library with test-containers
library, fixing the incompatibility issues with docker server 26.1.3
@EzequielPostan EzequielPostan force-pushed the fix-docker-library-failure-in-ci branch from 51d113a to 6ebb73d Compare July 3, 2024 21:26
Copy link
Contributor

@womfoo womfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EzequielPostan EzequielPostan merged commit e4cf875 into main Jul 4, 2024
8 checks passed
@EzequielPostan EzequielPostan deleted the fix-docker-library-failure-in-ci branch July 4, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants