fix(bash): Fix bash scripts finding relative references (as good as b…

…ash can)

earthly/bash/shellcheck-dir.sh

@@ -8,8 +8,13 @@ source "$(dirname "$0")/include/colors.sh"
 shopt -s globstar
 rc=0
 for file in "$1"/**/*.sh; do
+    path=$(dirname "${file}")
+    filename=$(basename "${file}")
+    pushd "${path}" >/dev/null || return 1
     status "${rc}" "Checking Bash Lint of '${file}'" \
-        shellcheck --check-sourced --external-sources --color=always --enable=all "${file}"
+        shellcheck --check-sourced --external-sources --color=always --enable=all "${filename}"
+    popd >/dev/null || return 1
+
     rc=$?
 done
 

earthly/postgresql/scripts/db_ops.sh

@@ -3,7 +3,13 @@
 # This script is not intended to be run by itself, and provides common functions
 # for database operations.
 
-basedir=$(dirname "$0")
+if [[ ${BASH_SOURCE[0]} = */* ]]; then
+    basedir=${BASH_SOURCE%/*}/
+else
+    basedir=./
+fi
+
+echo BASEDIR = "${basedir}"
 
 source "${basedir}/include/colors.sh"
 source "${basedir}/include/params.sh"

earthly/postgresql/scripts/std_build.sh

@@ -4,7 +4,11 @@
 # It validates that all the migrations and importable data are able to be
 # used without error.
 
-basedir=$(dirname "$0")
+if [[ ${BASH_SOURCE[0]} = */* ]]; then
+    basedir=${BASH_SOURCE%/*}
+else
+    basedir=.
+fi
 
 source "${basedir}/include/colors.sh"
 source "${basedir}/db_ops.sh"
@@ -46,7 +50,7 @@ do
 
     # Reset schema so all seed data get applied to a clean database.
     setup_and_migrate "Reset" "$@"
-done < <(find ./seed/* -maxdepth 1 -type d -print0 | sort -z)
+done < <(find ./seed/* -maxdepth 1 -type d -print0 | sort -z) || true
 
 # Stop the database
 status_and_exit "DB Stop" \

earthly/postgresql/scripts/std_checks.sh

@@ -9,7 +9,11 @@
 # Individual targets can add extra `check` steps, but these checks must always
 # pass. 
 
-basedir=$(dirname "$0")
+if [[ ${BASH_SOURCE[0]} = */* ]]; then
+    basedir=${BASH_SOURCE%/*}/
+else
+    basedir=./
+fi
 
 source "${basedir}/include/colors.sh"
 

earthly/rust/scripts/std_build.sh

@@ -9,7 +9,11 @@
 # Individual targets can add extra `check` steps, but these checks must always
 # pass. 
 
-basedir=$(dirname "$0")
+if [[ ${BASH_SOURCE[0]} = */* ]]; then
+    basedir=${BASH_SOURCE%/*}/
+else
+    basedir=./
+fi
 
 source "${basedir}/include/colors.sh"
 

earthly/rust/scripts/std_checks.sh

@@ -9,7 +9,11 @@
 # Individual targets can add extra `check` steps, but these checks must always
 # pass. 
 
-basedir=$(dirname "$0")
+if [[ ${BASH_SOURCE[0]} = */* ]]; then
+    basedir=${BASH_SOURCE%/*}/
+else
+    basedir=./
+fi
 
 source "${basedir}/include/colors.sh"
 

earthly/rust/scripts/verify_toolchain.sh

@@ -1,6 +1,10 @@
 #!/usr/bin/env bash
 
-basedir=$(dirname "$0")
+if [[ ${BASH_SOURCE[0]} = */* ]]; then
+    basedir=${BASH_SOURCE%/*}/
+else
+    basedir=./
+fi
 
 source "${basedir}/include/colors.sh"
 

utilities/scripts/bash/params.sh

@@ -17,30 +17,30 @@ get_param() {
     # Access the values of the associative arrays
     local env_var_map
     local default_map
-    declare -n env_var_map="$env_var_map_name"
-    declare -n default_map="$default_map_name"
+    declare -n env_var_map="${env_var_map_name}"
+    declare -n default_map="${default_map_name}"
     shift 3
 
     # Check if ENV_VAR defined, has priority over options and defaults
-    local env_var_name="${env_var_map[$param_name]:-}"
-    if [[ -n "$env_var_name" ]]; then
+    local env_var_name="${env_var_map[${param_name}]:-}"
+    if [[ -n "${env_var_name}" ]]; then
         local env_var_value="${!env_var_name}"
-        if [[ -n "$env_var_value" ]]; then
-            echo "$env_var_value"
+        if [[ -n "${env_var_value}" ]]; then
+            echo "${env_var_value}"
             return
         fi
     fi
 
     # Check for the parameter in the named options
     for arg in "$@"; do
-        if [[ "$arg" == "--$param_name="* ]]; then
+        if [[ "${arg}" == "--${param_name}="* ]]; then
             echo "${arg#*=}"
             return
         fi
     done
 
     # Return the default value
-    local default_value="${default_map[$param_name]:-}"
+    local default_value="${default_map[${param_name}]:-}"
     echo "${default_value:-}"
 
     return