-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): Rust guide #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, you have made a ton of unrelated changes to the code outside of the scope for the ticket.
The ticket did not ask you to rename +BUILDER to +SETUP that is disturbing to anyone else working on the code base, and also breaks cat-voices.
Even if that's a change we want to make and I don't know why we would, that needs to be a ticket all its own, and each target should be addressed separately.
Please revert all changes that have nothing to do with Rust documentation.
The task also was not to refactor or re-write the rust builder. So again, revert all that.
If you think the rust builder needs correction it needs to be raised in a ticket and properly discussed.
I have things in the builder for reasons. Especially to help us debug if things go wrong.
It doesn't;t cost us anything to print out the build platform data at the start of setting up the container.
Your setup assumes that rust-toolchain is with the Earthfile, it may not be.
There are so many changes to the rust builder that I can;t reason through it.
Your task was not to re-write it.
It was to document it ONLY.
I will not approve this PR unless it has only the following:
- Rust documentation.
- Fixes to demonstratable issues discovered while documenting it.
- You CAN move the rust example to the examples folder, but it should just be a move, and the changes in it should be limited to just that move (paths changing for example).
Given the work entailed in reverting, it is probably a lot faster to just re-branch the code from master, add the docs edited to suit the actual rust builder, and move the example. I strongly recommend this is what you do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Description
examples/rust
dir.Related Issue(s)
Closes #78
Please confirm the following checks