Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove local spellcheck targets #123

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Dec 7, 2023

Description

Remove the local spellcheck targets, UDCs, and workflows as we move away from using GitHub Actions.

Related Issue(s)

Closes #122

Description of Changes

  • removed the local spellcheck targets, UDCs, and workflows

Breaking Changes

  • removed the spell-check target. If any source is relying on this target, it needs to be updated.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the enhancement New feature or request label Dec 7, 2023
@apskhem apskhem requested a review from stevenj December 7, 2023 10:00
@apskhem apskhem self-assigned this Dec 7, 2023
@apskhem apskhem linked an issue Dec 7, 2023 that may be closed by this pull request
@apskhem apskhem added the draft Review only, do not merge yet label Dec 7, 2023
@stevenj stevenj enabled auto-merge (squash) December 7, 2023 15:02
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 3dd5518 into master Dec 7, 2023
25 checks passed
@stevenj stevenj deleted the fix/remove-spellcheck-targets branch December 7, 2023 15:03
@kukkok3 kukkok3 mentioned this pull request Dec 21, 2023
8 tasks
@alicechaitea alicechaitea mentioned this pull request Jan 9, 2024
8 tasks
@jmgilman jmgilman mentioned this pull request Jan 10, 2024
8 tasks
@kukkok3 kukkok3 mentioned this pull request Jan 10, 2024
8 tasks
@alicechaitea alicechaitea mentioned this pull request Jan 12, 2024
8 tasks
@alicechaitea alicechaitea mentioned this pull request Feb 22, 2024
8 tasks
@bkioshn bkioshn mentioned this pull request Apr 10, 2024
@kukkok3 kukkok3 mentioned this pull request May 8, 2024
8 tasks
@bkioshn bkioshn mentioned this pull request May 21, 2024
8 tasks
@stevenj stevenj mentioned this pull request May 22, 2024
8 tasks
@bkioshn bkioshn mentioned this pull request May 30, 2024
@kukkok3 kukkok3 mentioned this pull request Aug 1, 2024
8 tasks
@bkioshn bkioshn mentioned this pull request Oct 24, 2024
8 tasks
@emiride emiride mentioned this pull request Oct 28, 2024
8 tasks
This was referenced Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Review only, do not merge yet enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Clean up the local spellcheck from Earthfiles
2 participants