Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move target flags after target #151

Merged
merged 6 commits into from
Jan 11, 2024
Merged

fix: Move target flags after target #151

merged 6 commits into from
Jan 11, 2024

Conversation

kukkok3
Copy link
Contributor

@kukkok3 kukkok3 commented Jan 10, 2024

Description

Fixing target flags being parsed after the target leading to errors like this https://github.com/input-output-hk/catalyst-artifacts/actions/runs/7478641429/job/20354035906#step:7:39

Description of Changes

Moved target flags parsing after target

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #123, #456

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@kukkok3 kukkok3 requested a review from jmgilman January 10, 2024 18:03
@kukkok3 kukkok3 self-assigned this Jan 10, 2024
@kukkok3 kukkok3 marked this pull request as ready for review January 10, 2024 18:04
jmgilman
jmgilman previously approved these changes Jan 10, 2024
Copy link
Collaborator

@jmgilman jmgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This was a regression, thanks for fixing it.

@jmgilman jmgilman dismissed their stale review January 10, 2024 18:11

Fix test

@jmgilman jmgilman self-requested a review January 10, 2024 18:11
Copy link
Collaborator

@jmgilman jmgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to fix the failing test.

@kukkok3 kukkok3 enabled auto-merge (squash) January 10, 2024 18:21
@kukkok3 kukkok3 requested a review from jmgilman January 10, 2024 18:41
Copy link
Collaborator

@jmgilman jmgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 merged commit 7a775d5 into master Jan 11, 2024
52 checks passed
@kukkok3 kukkok3 deleted the fix-target-flag branch January 11, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants