Updated aarch64-unknown-linux-gnu rustflags, updated rust Earthly targets #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenj
requested changes
Oct 24, 2023
| ] | ||
|
|
||
| [target.aarch64-unknown-linux-gnu] | ||
| linker = "clang" | ||
| rustflags = [ | ||
| "-C", "link-arg=-fuse-ld=/usr/bin/mold", | ||
| "-C", "target-feature=+crt-static" | ||
| # "-C", "target-feature=+crt-static" - proc-macro doesn't work with it. `https://github.com/rust-lang/rust/issues/78210` |
There was a problem hiding this comment.
Thats not unexpected. The key point is to make sure when your target is built its NOT built with this target. This target can ONLY be used to build the compiler and its tooling.
There was a problem hiding this comment.
But it does not work for nextest, the same issue as with x86_64-unknown-linux-gnu
There was a problem hiding this comment.
nextest is just a tool, its ok to build it with the GNU tools. I hit this with x86 build as well. This is OK to disable for getting nextest to run.
| ] | ||
|
|
||
| [target.aarch64-unknown-linux-gnu] | ||
| linker = "clang" | ||
| rustflags = [ | ||
| "-C", "link-arg=-fuse-ld=/usr/bin/mold", | ||
| "-C", "target-feature=+crt-static" | ||
| # "-C", "target-feature=+crt-static" - proc-macro doesn't work with it. `https://github.com/rust-lang/rust/issues/78210` | ||
| ] | ||
|
|
||
| [target.aarch64-unknown-linux-musl] |
There was a problem hiding this comment.
This is the target target.aarch64-unknown-linux-musl catalyst-gateway should build with on an apple mac (or any AArch64 based device actually).
stevenj
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #53
target-feature=+crt-staticflagwith_cargo_nextest,with_cargo_chef,with_kani,with_refineryandwith_cargo_macheteearthly arguuments, so it is possible to conditionally install these tools.aarch64-unknown-linux-gnuwhen eathly rust targets are runned on the macOS M1: