Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: GcpUploader implements synchronization for Cardano database artifacts #2233

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Feat: GcpUploader implements synchronization for Cardano database artifacts #2233

wants to merge 9 commits into from

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 17, 2025 •
edited
Loading

Content

Important

WIP, not ready for review

This PR includes the update of the GcpUploader to support synchronization of Cardano database artifacts.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2211

@jpraynaud jpraynaud self-assigned this Jan 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   10m 44s ⏱️ +18s
1 530 tests +6  1 530 ✅ +6  0 💤 ±0  0 ❌ ±0 
1 786 runs  +6  1 786 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 441db86. ± Comparison against base commit f236320.

This pull request removes 3 and adds 9 tests. Note that renamed tests count towards both. 
mithril-aggregator ‑ dependency_injection::builder::tests::create_cardano_database_artifact_builder_creates_cardano_database_and_ancillary_directories_in_snapshot_directory
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::get_location_not_using_cdn_domain_return_google_api_uri
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::get_location_using_cdn_domain_return_cdn_in_uri

mithril-aggregator ‑ dependency_injection::builder::tests::build_cardano_database_artifact_builder_creates_cardano_database_and_ancillary_directories_in_snapshot_directory
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_fails_when_file_exists_fails_and_with_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_fails_when_make_public_fails
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_fails_when_upload_fails
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_succeeds_when_file_does_not_exist_remotely_and_with_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_succeeds_when_file_exists_remotely_and_with_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::cloud_backend_uploader::upload_public_file_succeeds_without_overwriting_allowed
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::gcp_backend_uploader::get_location_not_using_cdn_domain_return_google_api_uri
mithril-aggregator ‑ file_uploaders::gcp_uploader::tests::gcp_backend_uploader::get_location_using_cdn_domain_return_cdn_in_uri

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2211-artifact-gcp-synchro-cardano-database branch from 9bd86a1 to 75c02e0 Compare January 17, 2025 17:27
@jpraynaud jpraynaud force-pushed the jpraynaud/2211-artifact-gcp-synchro-cardano-database branch from 75c02e0 to 441db86 Compare January 17, 2025 17:30
@jpraynaud jpraynaud deployed to testing-preview January 17, 2025 17:40 — with GitHub Actions Active
@jpraynaud jpraynaud deployed to testing-sanchonet January 17, 2025 17:40 — with GitHub Actions Active
@jpraynaud jpraynaud deployed to dev-preview January 17, 2025 17:44 — with GitHub Actions Active
@jpraynaud jpraynaud deployed to dev-mainnet January 17, 2025 17:44 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement artifacts cloud synchronization in Incremental Cardano DB with GCP
1 participant
@jpraynaud