Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Signer node properly handles /register-signatures responses when the message has expired #2232

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix: Signer node properly handles /register-signatures responses when the message has expired #2232

wants to merge 4 commits into from

Conversation

dlachaume
Copy link
Collaborator

Content

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Closes #2229

@dlachaume
fix(aggregator): return HTTP 410 GONE on /register-signatures when …
3b7a6e1 
…the CertifierServiceError returned is expired
@dlachaume
refactor(aggregator): include error details in the HTTP 410 GONE resp…
e4c6b6e 
…onse body returned by the aggregator on the `/register-signatures` route
@dlachaume
refactor(signer): improve handling of GONE responses on calls to `/…
b550cfa 
…register_signatures` by logging the error from the aggregator's response body
@dlachaume
refactor(signer): remove the CONFLICT handling of the `register_sig…
d5a0626 
…natures` function
@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0     52 suites  ±0   10m 27s ⏱️ -1s
1 525 tests +1  1 525 ✅ +1  0 💤 ±0  0 ❌ ±0 
1 781 runs  +1  1 781 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit d5a0626. ± Comparison against base commit f236320.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both. 
mithril-aggregator ‑ http_server::routes::signatures_routes::tests::test_register_signatures_post_ko_410
mithril-signer ‑ services::aggregator_client::tests::test_register_signatures_ok_410

mithril-aggregator ‑ http_server::routes::signatures_routes::tests::test_register_signatures_post_ko_410_when_already_certified
mithril-aggregator ‑ http_server::routes::signatures_routes::tests::test_register_signatures_post_ko_410_when_expired
mithril-signer ‑ services::aggregator_client::tests::test_register_signatures_ok_410_log_response_body

@dlachaume dlachaume temporarily deployed to testing-sanchonet January 17, 2025 17:22 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signer does not handle properly signature signed entity timeout
1 participant
@dlachaume