Adds min package version #582

averissimo · 2023-07-18T11:03:40Z

WIP :: parent issue: insightsengineering/nestdevs-tasks#7

Supersede:

min deps #517

🔴 Checklist for PR Reviewer

Tag yourself next to this repo on Specify minimal version dependencies + add action nestdevs-tasks#7
Package versions are the same or higher than main
Package list is the same
All packages in Imports, Depends & Suggests are in new section Config/Needs/verdepcheck
Added entry to NEWS.md
Last scheduled.yaml action was run succesfully (all 4 strategies)
- important: it's not the last commit, it's the one that runs 4 Scheduled 🕰️ / Dependency actions
scheduled.yaml SHOULD NOT have any push on any branches

🔴 What's needed before merging?

This PR depends on some upstream changes that need to be finalized/merged before being ready to review.

Change in code

verdepcheck.yml action (see comments)
- Remove on: push section
- Change branch to main

PRS

verdepcheck
- Training verdepcheck#24
- Fixes and improvements for strategies verdepcheck#26
verdepcheck-action
- Supports new strategies min_isolated and min_cohort r-verdepcheck-action#16

Changes description

Adds minimum version for packages DESCRIPTION
Adds Config/Need/verdepcheck section in DESCRIPTION
Updates verdepcheck action

averissimo · 2023-07-27T08:59:18Z

rtables v0.6.2 needs to be released on CRAN for checks to pass

averissimo · 2023-12-18T12:46:00Z

This one is ready to be merged, all problems are solved now (see this action run)

clarkliming

looks good thank you

github-actions · 2023-12-18T12:54:15Z

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/ael01_nollt.R                 21       1  95.24%   72
R/aet01_aesi.R                 148       1  99.32%   211
R/aet01.R                       98       1  98.98%   168
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   114
R/aet10.R                       42       0  100.00%
R/assertions.R                  80       6  92.50%   10-15
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      149       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   129
R/dmt01.R                       37       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   50, 54-58
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   153
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       59       1  98.31%   50
R/fstg01.R                      44       0  100.00%
R/fstg02.R                      49       0  100.00%
R/kmg01.R                       29       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                       66       5  92.42%   123-128
R/lbt06.R                       70       3  95.71%   141-144
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       54       0  100.00%
R/mng01.R                       82       9  89.02%   82, 86-90, 110-111, 153
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/rmpt01.R                      59      11  81.36%   87-96, 131
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   155-158
R/rtables_utils.R              325      23  92.92%   51, 68, 119, 243, 264, 409-416, 483, 498-500, 502, 571-577, 587, 608
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     120       3  97.50%   201-204
R/utils.R                      157      21  86.62%   142, 157, 176-178, 295-298, 302-305, 332, 336, 348, 350, 362, 379-381
R/vst02.R                       45       1  97.78%   108
R/zzz.R                          1       1  0.00%    2
TOTAL                         3248     102  96.86%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                       +4       0  +0.04%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                 -19       0  -1.44%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +13      -4  +2.94%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +8       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                       -1       0  -0.03%
R/fstg01.R                      -6       0  +100.00%
R/fstg02.R                      -6       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                       -1       0  -0.11%
R/lbt06.R                       -2       0  -0.12%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -17       0  +100.00%
R/mng01.R                      -14      +8  -9.93%
R/pdt02.R                       -1       0  +100.00%
R/rmpt01.R                      -6       0  -1.72%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +25      +4  -0.74%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +3       0  +0.06%
R/utils.R                      +73     +21  -13.38%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +177     +27  -0.70%

Results for commit: caa17ac

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2023-12-18T12:57:59Z

Unit Tests Summary

    1 files   53 suites 3m 22s ⏱️
240 tests 170 ✔️   70 💤 0 ❌
465 runs 298 ✔️ 167 💤 0 ❌

Results for commit caa17ac.

github-actions · 2023-12-18T12:58:03Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
lbt14	💔	$29.42$	$+1.19$	$0$	$0$	$0$	$0$

Results for commit d260f81

♻️ This comment has been updated with latest results.

averissimo force-pushed the verdepcheck_action branch from 44fc73b to 37a03f1 Compare July 18, 2023 11:03

averissimo mentioned this pull request Jul 18, 2023

Specify minimal version dependencies + add action insightsengineering/nestdevs-tasks#7

Closed

55 tasks

averissimo force-pushed the verdepcheck_action branch from 37a03f1 to de4a42d Compare July 26, 2023 21:58

averissimo mentioned this pull request Jul 27, 2023

min deps #517

Closed

averissimo force-pushed the verdepcheck_action branch from de4a42d to 7b8c356 Compare September 4, 2023 10:33

averissimo added 6 commits December 18, 2023 11:41

docs: adds minimum version to dependencies

815278d

ci: adds temporary action on push

5f40447

ci: adds scheduled.yml instead of temporary action

0ec0252

ci: revert action to main branch and remove rmarkdown

71cf554

docs: typo on NEWS.md

78b1366

fix: readd rmarkdown to follow best practice from docs

1f04ddb

averissimo force-pushed the verdepcheck_action branch from 94d1d6f to 1f04ddb Compare December 18, 2023 11:44

averissimo added 2 commits December 18, 2023 11:52

fix: missing lifecycle

4bf9754

fix: bumps withr and diffr

1b79e8b

averissimo added the core label Dec 18, 2023

fix: remove workflow trigger on branch push

caa17ac

averissimo marked this pull request as ready for review December 18, 2023 12:46

averissimo requested a review from clarkliming as a code owner December 18, 2023 12:46

clarkliming approved these changes Dec 18, 2023

View reviewed changes

clarkliming merged commit 5073136 into main Dec 18, 2023
48 checks passed

clarkliming deleted the verdepcheck_action branch December 18, 2023 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds min package version #582

Adds min package version #582

averissimo commented Jul 18, 2023 •

edited

Loading

averissimo commented Jul 27, 2023

averissimo commented Dec 18, 2023

clarkliming left a comment

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

github-actions bot commented Dec 18, 2023

Adds min package version #582

Adds min package version #582

Conversation

averissimo commented Jul 18, 2023 • edited Loading

🔴 Checklist for PR Reviewer

🔴 What's needed before merging?

Change in code

PRS

Changes description

averissimo commented Jul 27, 2023

averissimo commented Dec 18, 2023

clarkliming left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 18, 2023

Code Coverage Summary

Diff against main

github-actions bot commented Dec 18, 2023

Unit Tests Summary

github-actions bot commented Dec 18, 2023

Unit Test Performance Difference

averissimo commented Jul 18, 2023 •

edited

Loading