Updates

.github/workflows/lint.yaml

@@ -28,6 +28,18 @@ jobs:
         with:
           fetch-depth: 0
 
+      - name: Override SuperLinter configs 💾
+        run: |
+          # Override markdownlint default config
+          [ ! -e .markdownlint.yaml ] && cat > .markdownlint.yaml <<EOF
+          ###############
+          # Rules by id #
+          ###############
+          MD013:
+            line_length: 1200 # Line length
+          EOF
+        shell: bash
+
       - name: Lint Code Base 🕵🏻‍♀️
         uses: github/super-linter/slim@v4
         env:

cmd/construct.go

@@ -67,14 +67,6 @@ func resolveDependenciesRecursively(outputList *[]OutputPackage, name string, ve
 	for i := 0; i < recursionLevel; i++ {
 		indentation += "  "
 	}
-	if checkIfBasePackage(name) {
-		log.Debug(indentation, "Skipping package ", name, " as it is a base R package.")
-		return
-	}
-	if checkIfPackageOnOutputList(name, *outputList) {
-		log.Debug(indentation, "Package ", name, " is already present on the output list.")
-		return
-	}
 	for _, r := range repositoryList {
 		// Check if the package is present in the PACKAGES file for the repository.
 		for _, p := range packagesFiles[r].Packages {
@@ -116,6 +108,7 @@ func resolveDependenciesRecursively(outputList *[]OutputPackage, name string, ve
 			}
 		}
 	}
+	// TODO Should we fail in this case?
 	var versionConstraint string
 	if versionOperator != "" && versionValue != "" {
 		versionConstraint = " in version " + versionOperator + " " + versionValue

cmd/construct_test.go

@@ -316,6 +316,18 @@ func Test_constructOutputPackageList(t *testing.T) {
 						"",
 						"",
 					},
+					{
+						"Suggests",
+						"package16",
+						"",
+						"",
+					},
+					{
+						"Suggests",
+						"package1",
+						"",
+						"",
+					},
 					{
 						"Imports",
 						"package8",
@@ -328,6 +340,12 @@ func Test_constructOutputPackageList(t *testing.T) {
 						">=",
 						"2.3",
 					},
+					{
+						"Depends",
+						"non.existent.package",
+						"<",
+						"4.0.4",
+					},
 					{
 						"LinkingTo",
 						"package10",

cmd/parse.go

@@ -130,6 +130,10 @@ func cleanDescriptionOrPackagesEntry(description string) string {
 	return outputContent
 }
 
+func splitPackageName(r rune) bool {
+	return r == ' ' || r == '('
+}
+
 // Processes a map containing a YAML-like object representing dependencies of a package.
 // Returns a list of Dependency structures corresponding to dependency name, and version constraints.
 func processDependencyFields(packageMap map[string]string,
@@ -140,7 +144,10 @@ func processDependencyFields(packageMap map[string]string,
 		if _, ok := packageMap[field]; ok {
 			dependencyList := strings.Split(packageMap[field], ", ")
 			for _, dependency := range dependencyList {
-				dependencyName := strings.Split(dependency, " ")[0]
+				// There might be a space or '(' right after the package name,
+				// so both space and '(' are treated as a delimiter to get the
+				// package name from the first field.
+				dependencyName := strings.FieldsFunc(dependency, splitPackageName)[0]
 				versionConstraintOperator := ""
 				versionConstraintValue := ""
 				// Check if package is required in some particular version.

cmd/testdata/DESCRIPTION1

@@ -7,7 +7,7 @@ Description: This is a multiline string
     representing package description.
 License: Apache License 2.0
 Depends:
-    R (>= 4.0),
+    R(>= 4.0),
     shiny (>= 1.7.0)
 Imports:
     checkmate,

cmd/testdata/DESCRIPTION2

@@ -10,7 +10,7 @@ Depends:
 Imports:
     dplyr,
     forcats (>= 1.0.0), formatters (>= 0.5.3),
-    ggplot2 (>= 3.4.0),
+    ggplot2(>= 3.4.0),
     stats,
     survival (>=
         3.2-13),