Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow incomplete renv.lock #10

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Allow incomplete renv.lock #10

merged 8 commits into from
Nov 16, 2023

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented Nov 16, 2023

  • Add a new --allowIncompleteRenvLock flag to let the renv.lock generation proceed even in case of dependencies missing from given repositories (the missing dependency types are customizable).
  • Handle a situation where there are two entries in PACKAGES file for the same package but one of them points to a subdirectory specified in Path: field (e.g. latest/src/contrib/4.4.0/Recommended/).

Copy link

github-actions bot commented Nov 16, 2023

Unit Tests Summary

8 tests   8 ✔️  0s ⏱️
2 suites  0 💤
1 files    0

Results for commit 8f7c98b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 16, 2023

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------------------------------------------------------------------------
cmd/construct.go      174      16  90.80%   55-57, 124-126, 131-134, 166-168, 252-254
cmd/download.go       173      51  70.52%   50-70, 89-91, 108-110, 137-139, 155-157, 177-179, 220-228, 241-245, 252-254
cmd/parse.go          116      12  89.66%   36-42, 52-53, 66-68
cmd/renv.go            26       0  100.00%
cmd/root.go           132     129  2.27%    49-135, 142-196
cmd/utils.go           76      31  59.21%   27-29, 52-63, 71-73, 81-83, 94-96, 117-123
TOTAL                 697     239  65.71%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
cmd/construct.go      +13      +2  -0.50%
cmd/parse.go          +13       0  +1.31%
cmd/root.go            +6      +6  -0.11%
cmd/utils.go           +5       0  +2.87%
TOTAL                 +37      +8  +0.71%

Results for commit: 8f7c98b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@walkowif walkowif marked this pull request as ready for review November 16, 2023 13:59
@walkowif walkowif requested a review from a team as a code owner November 16, 2023 13:59
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walkowif walkowif merged commit dadf06a into main Nov 16, 2023
7 checks passed
@walkowif walkowif deleted the allow-incomplete-renv-lock branch November 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants