Refactor ADPC

[qiliu1013]

fixed #280

[github-actions]

Unit Tests Summary

    1 files    4 suites   36s ⏱️
  61 tests 40 ✔️ 21 💤 0 ❌
106 runs  85 ✔️ 21 💤 0 ❌

Results for commit fbb11ec.

♻️ This comment has been updated with latest results.

[shajoezhu]

hi @qiliu1013 , there was a minor bug in the yml file, i just fixed. can you please

1. update and recompile the dataset
2. please update radab function accordingly as well. I am getting the following error message

> cadab_new <- radab(cadsl_new, cadpc_new, seed = 1, na_vars = list()) %>% `attr<-`("creation date", Sys.Date())
Error in `dplyr::select()`:
! Can't subset columns that don't exist.
✖ Column `ARELTM1` doesn't exist.
Backtrace:
  1. ... %>% `attr<-`("creation date", Sys.Date())
 14. dplyr:::select.data.frame(...)

Thanks

[qiliu1013]

hi @qiliu1013 , there was a minor bug in the yml file, i just fixed. can you please

1. update and recompile the dataset
2. please update radab function accordingly as well. I am getting the following error message

> cadab_new <- radab(cadsl_new, cadpc_new, seed = 1, na_vars = list()) %>% `attr<-`("creation date", Sys.Date())
Error in `dplyr::select()`:
! Can't subset columns that don't exist.
✖ Column `ARELTM1` doesn't exist.
Backtrace:
  1. ... %>% `attr<-`("creation date", Sys.Date())
 14. dplyr:::select.data.frame(...)

Thanks

@shajoezhu, I updated ADAB, however apply_metadata(adpc, "metadata/ADPC.yml") still doesn't work for me.

[github-actions]

Code Coverage Summary

Filename         Stmts    Miss  Cover    Missing
-------------  -------  ------  -------  --------------------------
R/radab.R          293       1  99.66%   398
R/radae.R          198       3  98.48%   77, 96, 285
R/radaette.R       203       4  98.03%   51, 73, 79, 261
R/radcm.R          150       2  98.67%   52, 205
R/raddv.R           91       2  97.80%   55, 138
R/radeg.R          270       1  99.63%   371
R/radex.R          229       1  99.56%   321
R/radhy.R          136       1  99.26%   199
R/radlb.R          334       1  99.70%   427
R/radmh.R           93       2  97.85%   46, 135
R/radpc.R           83       1  98.80%   124
R/radpp.R           81       1  98.77%   152
R/radqlqc.R        985       7  99.29%   336, 849, 1105-1109
R/radqs.R          118       1  99.15%   186
R/radrs.R          122       3  97.54%   48, 55, 184
R/radsaftte.R        1       0  100.00%
R/radsl.R          180       1  99.44%   262
R/radsub.R         140       2  98.57%   179, 243
R/radtr.R          124       0  100.00%
R/radtte.R         208       4  98.08%   53, 73, 85, 280
R/radvs.R          178       1  99.44%   252
R/utils.R          148      11  92.57%   62, 251, 263, 267, 296-302
TOTAL             4365      50  98.85%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  -------
R/radpc.R         +9       0  +0.15%
R/radqlqc.R       +3       0  +0.00%
TOTAL            +12       0  +0.00%

Results for commit: e5ae522

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[shajoezhu]

Thanks @qiliu1013 , I have made a few updates.

hey @edelarua, I was wondering if I could get second opinion as well? Thanks!

[edelarua]

Lgtm! @qiliu1013 @shajoezhu