Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove g_forest tests #110

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Remove g_forest tests #110

merged 6 commits into from
Jan 22, 2024

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Jan 22, 2024

Closes #109

Reverts changes from #87

@edelarua edelarua added the sme label Jan 22, 2024
Copy link
Contributor

github-actions bot commented Jan 22, 2024

Unit Tests Summary

  1 files  111 suites   5m 42s ⏱️
245 tests 234 ✅  11 💤 0 ❌
499 runs  256 ✅ 243 💤 0 ❌

Results for commit 4230506.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $16.13$ $-1.14$ $0$ $0$ $0$ $0$
table_aet02 💚 $10.98$ $-1.36$ $0$ $0$ $0$ $0$
table_aet04 💚 $15.56$ $-1.39$ $0$ $0$ $0$ $0$
table_aet04_pi 💚 $10.18$ $-1.50$ $0$ $0$ $0$ $0$
table_ent 💚 $19.83$ $-1.50$ $0$ $0$ $0$ $0$
table_fstg01 💀 $7.18$ $-7.18$ $-5$ $-5$ $0$ $0$
table_fstg02 💀 $2.82$ $-2.82$ $-8$ $-4$ $0$ $0$
table_lbt05 💚 $25.65$ $-1.79$ $0$ $0$ $0$ $0$
table_lbt14 💚 $140.26$ $-15.92$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_fstg01 💀 $1.76$ $-1.76$ FSTG01_variant_1_is_produced_correctly
table_fstg01 💀 $1.55$ $-1.55$ FSTG01_variant_2_is_produced_correctly
table_fstg01 💀 $0.88$ $-0.88$ FSTG01_variant_3_is_produced_correctly
table_fstg01 💀 $1.49$ $-1.49$ FSTG01_variant_4_is_produced_correctly
table_fstg01 💀 $1.51$ $-1.51$ FSTG01_variant_5_is_produced_correctly
table_fstg02 💀 $0.83$ $-0.83$ FSTG02_table_variant_1_Subgroup_Analysis_of_Survival_Duration_is_produced_correctly
table_fstg02 💀 $0.76$ $-0.76$ FSTG02_table_variant_2_specifying_class_variables_and_options_for_the_treatment_variable_
table_fstg02 💀 $0.45$ $-0.45$ FSTG02_table_variant_3_selecting_columns_and_changing_the_alpha_level_
table_fstg02 💀 $0.79$ $-0.79$ FSTG02_table_variant_4_fixed_symbol_size_is_produced_correctly
table_lbt14 💚 $31.39$ $-3.82$ LBT14_variant_1_HIGH_works_as_expected
table_lbt14 💚 $28.46$ $-2.40$ LBT14_variant_2_LOW_works_as_expected
table_lbt14 💚 $26.61$ $-2.80$ LBT14_variant_4_LOW_and_force_1_missing_both_baseline_and_post_baseline_then_force_the_missing_baseline_as_0_as_expected
table_lbt14 💚 $44.62$ $-6.32$ LBT14_variant_5_HIGH_with_fillings_works_as_expected

Results for commit 0bbc427

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu enabled auto-merge (squash) January 22, 2024 23:47
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @edelarua , let's give this a try today. and see if this fixes the other testings

@shajoezhu shajoezhu merged commit e88b5ff into main Jan 22, 2024
24 checks passed
@shajoezhu shajoezhu deleted the 109_remove_g_forest@main branch January 22, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove g_forest tests
2 participants