Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ratet01 test #117

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Remove ratet01 test #117

merged 3 commits into from
Jan 26, 2024

Conversation

edelarua
Copy link
Contributor

Closes #113

@edelarua edelarua added the sme label Jan 25, 2024
Copy link
Contributor

github-actions bot commented Jan 25, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $16.38$ $-1.72$ $0$ $0$ $0$ $0$
table_aet04 💚 $15.01$ $-1.26$ $0$ $0$ $0$ $0$
table_ent 💚 $19.67$ $-1.66$ $0$ $0$ $0$ $0$
table_lbt05 💚 $25.29$ $-2.38$ $0$ $0$ $0$ $0$
table_lbt14 💚 $134.12$ $-12.67$ $0$ $0$ $0$ $0$
table_ratet01 💀 $0.64$ $-0.64$ $-2$ $-1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_lbt05 💚 $9.90$ $-1.24$ LBT05_variant_1_is_produced_correctly
table_lbt14 💚 $29.75$ $-3.12$ LBT14_variant_1_HIGH_works_as_expected
table_lbt14 💚 $27.96$ $-2.39$ LBT14_variant_2_LOW_works_as_expected
table_lbt14 💚 $9.18$ $-1.03$ LBT14_variant_3_LOW_without_baseline_missing_works_as_expected
table_lbt14 💚 $25.55$ $-2.09$ LBT14_variant_4_LOW_and_force_1_missing_both_baseline_and_post_baseline_then_force_the_missing_baseline_as_0_as_expected
table_lbt14 💚 $41.68$ $-4.04$ LBT14_variant_5_HIGH_with_fillings_works_as_expected
table_ratet01 💀 $0.64$ $-0.64$ RATET01_is_produced_correctly

Results for commit c0c6751

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Tests Summary

  1 files  110 suites   5m 32s ⏱️
244 tests 233 ✅  11 💤 0 ❌
497 runs  255 ✅ 242 💤 0 ❌

Results for commit d318c2f.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @edelarua

@shajoezhu shajoezhu merged commit 4b4af7d into main Jan 26, 2024
24 checks passed
@shajoezhu shajoezhu deleted the 113_remove_ratet01@main branch January 26, 2024 04:34
@shajoezhu shajoezhu self-assigned this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

temporary removal for rate01 (due to change after tern 0.9.3), reinstate after tmc cran release
2 participants