-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #107, #132, #134 pharmaverseadam updates for pk/pd #140
Closes #107, #132, #134 pharmaverseadam updates for pk/pd #140
Conversation
Unit Tests Summary 1 files 111 suites 3m 6s ⏱️ Results for commit b4f2300. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 154550d ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! I'm not familiar with the specs for each table (i.e. if it's ok to drop the columns you did) but I'm sure you know better than I do. Just a few comments/suggestions from me :)
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com> Signed-off-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com> Signed-off-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
I didn't really drop columns as much as it was the dataset isn't as "rich" as the previous, we only have 1 analyte for urine where the doses are just different in the pharamverseadam data so there's no "Drug Y" equivalent to look at @shajoezhu do you have thoughts how this has been handled? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks Zelos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @zdz2101 dont worry for drug y for now
No description provided.