Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #107, #132, #134 pharmaverseadam updates for pk/pd #140

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

zdz2101
Copy link
Collaborator

@zdz2101 zdz2101 commented May 30, 2024

No description provided.

Copy link
Contributor

github-actions bot commented May 30, 2024

Unit Tests Summary

  1 files  111 suites   3m 6s ⏱️
243 tests 213 ✅  30 💤 0 ❌
476 runs  235 ✅ 241 💤 0 ❌

Results for commit b4f2300.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 30, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
table_ent 💔 $14.04$ $+1.01$ $0$ $0$ $0$ $0$
table_lbt14 💔 $28.62$ $+1.90$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
table_pkpt04 💀 $0.24$ $-0.24$ PKPT04_is_produced_correctly_for_Drug_Y
table_pkpt05 💀 $0.35$ $-0.35$ PKPT05_Drug_Y_is_produced_correctly

Results for commit 154550d

♻️ This comment has been updated with latest results.

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! I'm not familiar with the specs for each table (i.e. if it's ok to drop the columns you did) but I'm sure you know better than I do. Just a few comments/suggestions from me :)

tests/testthat/test-listing_pkcl02.R Outdated Show resolved Hide resolved
tests/testthat/test-listing_pkpl02.R Outdated Show resolved Hide resolved
tests/testthat/_snaps/listing_pkpl04.md Show resolved Hide resolved
zdz2101 and others added 3 commits May 31, 2024 18:05
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com>
Signed-off-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
Co-authored-by: Emily de la Rua <59304861+edelarua@users.noreply.github.com>
Signed-off-by: Zelos Zhu <zelos.zhu@atorusresearch.com>
@zdz2101
Copy link
Collaborator Author

zdz2101 commented May 31, 2024

Looks good!! I'm not familiar with the specs for each table (i.e. if it's ok to drop the columns you did) but I'm sure you know better than I do. Just a few comments/suggestions from me :)

I didn't really drop columns as much as it was the dataset isn't as "rich" as the previous, we only have 1 analyte for urine where the doses are just different in the pharamverseadam data so there's no "Drug Y" equivalent to look at

@shajoezhu do you have thoughts how this has been handled?

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Zelos

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @zdz2101 dont worry for drug y for now

@zdz2101 zdz2101 merged commit 8308434 into main Jun 4, 2024
30 checks passed
@zdz2101 zdz2101 deleted the 132_134_pharmaverseadam_updates@adpp_adpc_update branch June 4, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants