update snapshots with new align #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melkiades
commented
Jul 17, 2023
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Melkiades
commented
Jul 17, 2023
…ineering/scda.test into 135_fix_align_left@57_fix_after_align_left@main
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
Melkiades
commented
Jul 19, 2023
Melkiades
commented
Jul 19, 2023
Comment on lines
+16
to
+19
| default_formatting = list( | ||
| all = formatters::fmt_config(align = "left"), | ||
| numeric = formatters::fmt_config(align = "center") | ||
| ), |
There was a problem hiding this comment.
took this from @BFalquet. If we need to set it up everywhere better to start now ;)
There was a problem hiding this comment.
Also, is this a default @barnett11? I cannot find the issue where you talked about this, sorry
There was a problem hiding this comment.
This was the discussion, left alignment is needed for this template
https://github.com/insightsengineering/sme-tasks/issues/619
shajoezhu
reviewed
Jul 19, 2023
shajoezhu
requested changes
Jul 19, 2023
Co-authored-by: Joe Zhu <sha.joe.zhu@gmail.com> Signed-off-by: Davide Garolini <dgarolini@gmail.com>
|
@shajoezhu could you take a look at this again please? |
|
sorry, I had missed this tag before. @Melkiades , could you please update the code and rerun tests please. thanks! |
Signed-off-by: Davide Garolini <dgarolini@gmail.com>
ready @shajoezhu! :) |
shajoezhu
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes insightsengineering/sme-tasks#57 to be merged only after insightsengineering/rlistings#136