Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests using ADPC after refactor #60

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix tests using ADPC after refactor #60

merged 2 commits into from
Jul 18, 2023

Conversation

edelarua
Copy link
Contributor

Closes #59

Aligns with Pawel's changes in insightsengineering/tlg-catalog#69 (could be be made into separate PR within tlg-catalog)

ADAL02 template still likely requires refactoring after data changes.

@edelarua edelarua added the sme label Jul 18, 2023
@edelarua edelarua mentioned this pull request Jul 18, 2023
Closed
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files  112 suites   2m 49s ⏱️
246 tests 235 ✔️   11 💤 0 ❌
495 runs  250 ✔️ 245 💤 0 ❌

Results for commit a76215d.

Melkiades
Melkiades approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Emily :))

@edelarua edelarua merged commit df67a7d into main Jul 18, 2023
24 checks passed
@edelarua edelarua deleted the 59_adpc_update@main branch July 18, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt after update ADPC
2 participants
@edelarua @Melkiades